Bug 1547084 Part 1 - Remove recordReplayDirective interface and uses, r=mccr8.

--HG--
extra : rebase_source : 9fcddba95a4759fe6eb1222199ad8eeaaba2e146

devtools/client/webreplay/mochitest/browser_dbg_rr_breakpoints-03.js

@@ -9,15 +9,12 @@
 // Test some issues when stepping around after hitting a breakpoint while recording.
 add_task(async function() {
   const dbg = await attachRecordingDebugger("doc_rr_continuous.html");
-  const {threadClient, tab, toolbox, target} = dbg;
+  const {threadClient, tab, toolbox} = dbg;
 
   await threadClient.interrupt();
   const bp1 = await setBreakpoint(threadClient, "doc_rr_continuous.html", 19);
   await resumeToLine(threadClient, 19);
   await reverseStepOverToLine(threadClient, 18);
-  await checkEvaluateInTopFrame(target,
-    "SpecialPowers.Cu.recordReplayDirective(/* AlwaysTakeTemporarySnapshots */ 3)",
-    undefined);
   await stepInToLine(threadClient, 22);
   const bp2 = await setBreakpoint(threadClient, "doc_rr_continuous.html", 24);
   await resumeToLine(threadClient, 24);

devtools/client/webreplay/mochitest/examples/doc_rr_basic.html

@@ -32,7 +32,5 @@ function testStepping2() {
   c--;
 }
 window.setTimeout(f, 1);
-// Simulate a longer recording by marking major checkpoints whenever possible.
-SpecialPowers.Cu.recordReplayDirective(/* AlwaysMarkMajorCheckpoints */ 4);
 </script>
 </html>

devtools/client/webreplay/mochitest/examples/doc_rr_logs.html

@@ -22,7 +22,5 @@ function f() {
   window.setTimeout(recordingFinished);
 }
 window.setTimeout(f, 1);
-// Simulate a longer recording by marking major checkpoints whenever possible.
-SpecialPowers.Cu.recordReplayDirective(/* AlwaysMarkMajorCheckpoints */ 4);
 </script>
 </html>

js/xpconnect/idl/xpccomponents.idl

@@ -669,9 +669,6 @@ interface nsIXPCComponents_Utils : nsISupports
      */
     AUTF8String readUTF8URI(in nsIURI url);
 
-    /* Give a directive to the record/replay system. */
-    void recordReplayDirective(in long directive);
-
     /* Create a spellchecker object. */
     nsIEditorSpellCheck createSpellChecker();
 

js/xpconnect/src/XPCComponents.cpp

@@ -2409,12 +2409,6 @@ nsXPCComponents_Utils::Now(double* aRetval) {
   return NS_OK;
 }
 
-NS_IMETHODIMP
-nsXPCComponents_Utils::RecordReplayDirective(int aDirective) {
-  recordreplay::RecordReplayDirective(aDirective);
-  return NS_OK;
-}
-
 NS_IMETHODIMP
 nsXPCComponents_Utils::CreateSpellChecker(nsIEditorSpellCheck** aSpellChecker) {
   NS_ENSURE_ARG_POINTER(aSpellChecker);

mfbt/RecordReplay.cpp

@@ -80,9 +80,7 @@ namespace recordreplay {
                             (aData, aSize)) Macro(InternalRegisterThing,       \
                                                   (void* aThing), (aThing))    \
                           Macro(InternalUnregisterThing, (void* aThing),       \
-                                (aThing)) Macro(InternalRecordReplayDirective, \
-                                                (long aDirective),             \
-                                                (aDirective))                  \
+                                (aThing))                                      \
                               Macro(BeginContentParse,                         \
                                     (const void* aToken, const char* aURL,     \
                                      const char* aContentType),                \

mfbt/RecordReplay.h

@@ -258,10 +258,6 @@ static inline void RegisterThing(void* aThing);
 static inline void UnregisterThing(void* aThing);
 static inline size_t ThingIndex(void* aThing);
 
-// Give a directive to the record/replay system. For possible values for
-// aDirective, see ProcessRecordReplay.h. This is used for testing purposes.
-static inline void RecordReplayDirective(long aDirective);
-
 // Helper for record/replay asserts, try to determine a name for a C++ object
 // with virtual methods based on its vtable.
 static inline const char* VirtualThingName(void* aThing);
@@ -440,8 +436,6 @@ MOZ_MAKE_RECORD_REPLAY_WRAPPER_VOID(UnregisterThing, (void* aThing), (aThing))
 MOZ_MAKE_RECORD_REPLAY_WRAPPER(ThingIndex, size_t, 0, (void* aThing), (aThing))
 MOZ_MAKE_RECORD_REPLAY_WRAPPER(VirtualThingName, const char*, nullptr,
                                (void* aThing), (aThing))
-MOZ_MAKE_RECORD_REPLAY_WRAPPER_VOID(RecordReplayDirective, (long aDirective),
-                                    (aDirective))
 
 #undef MOZ_MAKE_RECORD_REPLAY_WRAPPER_VOID
 #undef MOZ_MAKERECORDREPLAYWRAPPER