Bug 1289301 - Remove the call to Shutdown() from MediaDecoder::NetworkError(). r=cpearce

MozReview-Commit-ID: EuDKW2KZQ9n

--HG--
extra : rebase_source : 7330327d6194a6fa45905d1ff52d258e58b96a4b

dom/media/MediaDecoder.cpp

@@ -1041,7 +1041,7 @@ MediaDecoder::NetworkError()
   MOZ_ASSERT(NS_IsMainThread());
   MOZ_ASSERT(!IsShutdown());
   mOwner->NetworkError();
-  Shutdown();
+  MOZ_ASSERT(IsShutdown());
 }
 
 void

dom/media/MediaDecoderOwner.h

@@ -57,8 +57,10 @@ public:
   // when it has read the first frame of the video or audio.
   virtual void FirstFrameLoaded() = 0;
 
-  // Called by the video decoder object, on the main thread,
+  // Called by the decoder object, on the main thread,
   // when the resource has a network error during loading.
+  // The decoder owner should call Shutdown() on the decoder and drop the
+  // reference to the decoder to prevent further calls into the decoder.
   virtual void NetworkError() = 0;
 
   // Called by the decoder object, on the main thread, when the