From a3215ffb228e2026e1b37e63c980f72bc692e02a Mon Sep 17 00:00:00 2001 From: Bogdan Postelnicu Date: Fri, 27 Nov 2015 06:24:00 +0100 Subject: [PATCH] Bug 1192982 - increase buffer size, memset it to 0 and then do the right way strncpy. r=jaas --- dom/plugins/test/testplugin/nptest.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/dom/plugins/test/testplugin/nptest.cpp b/dom/plugins/test/testplugin/nptest.cpp index 0024578b1f5c..6e3dc640a9b0 100644 --- a/dom/plugins/test/testplugin/nptest.cpp +++ b/dom/plugins/test/testplugin/nptest.cpp @@ -428,8 +428,13 @@ static void clearIdentifiers() static void addRange(InstanceData* instanceData, const char* range) { - char rangestr[16]; - strncpy(rangestr, range, sizeof(rangestr)); + /* + increased rangestr size from 16 to 17, the 17byte is only for + null terminated value, maybe for actual capacity it needs 16 bytes + */ + char rangestr[17]; + memset(rangestr, 0, sizeof(rangestr)); + strncpy(rangestr, range, sizeof(rangestr) - sizeof(char)); const char* str1 = strtok(rangestr, ","); const char* str2 = str1 ? strtok(nullptr, ",") : nullptr; if (str1 && str2) {