diff --git a/browser/devtools/framework/test/browser_toolbox_options.js b/browser/devtools/framework/test/browser_toolbox_options.js index 88c85cc17247..88d4cce8c9d0 100644 --- a/browser/devtools/framework/test/browser_toolbox_options.js +++ b/browser/devtools/framework/test/browser_toolbox_options.js @@ -50,11 +50,15 @@ function* testSelectTool() { function* testOptionsShortcut() { info ("Selecting another tool, then reselecting options panel with keyboard."); - yield toolbox.selectTool("webconsole") - .then(() => synthesizeKeyFromKeyTag("toolbox-options-key", doc)) - .then(() => { - ok(true, "Toolbox selected via shortcut key"); - }); + yield toolbox.selectTool("webconsole"); + is(toolbox.currentToolId, "webconsole", "webconsole is selected"); + synthesizeKeyFromKeyTag("toolbox-options-key", doc); + is(toolbox.currentToolId, "options", "Toolbox selected via shortcut key (1)"); + + yield toolbox.selectTool("webconsole"); + is(toolbox.currentToolId, "webconsole", "webconsole is selected"); + synthesizeKeyFromKeyTag("toolbox-options-key2", doc); + is(toolbox.currentToolId, "options", "Toolbox selected via shortcut key (2)"); } function* testOptions() { diff --git a/browser/devtools/framework/toolbox.js b/browser/devtools/framework/toolbox.js index 71053561200a..932a8e27007a 100644 --- a/browser/devtools/framework/toolbox.js +++ b/browser/devtools/framework/toolbox.js @@ -457,10 +457,11 @@ Toolbox.prototype = { }, _buildOptions: function() { + let selectOptions = () => { this.selectTool("options"); }; let key = this.doc.getElementById("toolbox-options-key"); - key.addEventListener("command", () => { - this.selectTool("options"); - }, true); + key.addEventListener("command", selectOptions, true); + let key2 = this.doc.getElementById("toolbox-options-key2"); + key2.addEventListener("command", selectOptions, true); }, _splitConsoleOnKeypress: function(e) { diff --git a/browser/devtools/framework/toolbox.xul b/browser/devtools/framework/toolbox.xul index 0a9ca9b8c5c4..11a380a001e4 100644 --- a/browser/devtools/framework/toolbox.xul +++ b/browser/devtools/framework/toolbox.xul @@ -9,9 +9,11 @@ - %toolboxDTD; +%toolboxDTD; %editMenuStrings; + +%globalKeysDTD; ]> @@ -30,6 +32,9 @@ key="&toolboxOptionsButton.key;" oncommand="void(0);" modifiers="shift, accel"/> +