mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1768935: Reduce sizes in grid-abspos-items-015.html (and -016 and their reference case) to fit in reftest viewport. r=dshin 

Before this change, each "line" has 6 floats, each of which has a border-box
that's 138px wide. So, each line has a total width of 828px.

Unfortunately this is too wide for the 800x1000 reftest viewport (as described
in reftest.jsm), so each line wraps a single float.  This looks awkward, but
worse, it means the test as a whole ends up being twice as tall as we intend
for it to be, and some of the content gets pushed off the bottom of the
viewport and doesn't get compared in the reftest harness.

After this change, each float's border-box is 8px skinnier (130px wide), which
puts each line at 780px, which is skinny enough to fit without wrapping.

I'm also changing various hardcoded coordinates in the reference case by 8px as
well, to keep the testcase passing.

I've also made a 1px change to the reference case's 'bottom' declaration in the
very last line, to fix a preexisting bug that gets uncovered by this fix. This
value has been off by 1px, which should have been causing a test failure, but
wasn't detected by the harness because this part was outside of the viewport.
Now it's inside the viewport, so we can see that it was wrong and we can fix it
here.  (Note that you can see this preexisting issue locally by comparing
un-patched versions of the testcase and reference case in a regular browser
window, looking at the very bottom-right corner.)

Differential Revision: https://phabricator.services.mozilla.com/D146126
This commit is contained in:
Daniel Holbert 2022-05-12 18:58:47 +00:00
Родитель 2eb0bf9d4d
Коммит a385fbef2d
3 изменённых файлов: 9 добавлений и 9 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

14
layout/reftests/css-grid/grid-abspos-items-015-ref.html
Просмотреть файл

@ -5,7 +5,7 @@
-->
<html><head>
<meta charset="utf-8">
<title>CSS Grid Test: abs pos static position (ancestor of grid container as abs.pos. CB)</title>
<title>CSS Grid Reference: abs pos static position (ancestor of grid container as abs.pos. CB)</title>
<link rel="author" title="Mats Palmgren" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1151243">
<style type="text/css">
html,body {
@ -20,7 +20,7 @@ separator { clear:both; display:block; height:6px; }
grid-template: 25px 33px 7px / 30px 51px 5px;
margin-right: 4px;
height: 100px;
width: 100px;
width: 92px;
}
.wrap {
position: relative;
@ -40,7 +40,7 @@ abs1,abs2,abs3,abs4 {
}
abs1 { height:97px; top:-12px; left:-30px; background:lime; }
abs2 { right:-18px; left:3px; background:pink; }
abs3 { top: -20px; left:-35px; right:-26px; background:cyan; }
abs3 { top: -20px; left:-35px; right:-18px; background:cyan; }
abs4 { top:-6px; bottom:-53px; background:silver; }
abs1::before { content:"1";}
abs2::before { content:"2";}
@ -55,9 +55,9 @@ abs4::before { content:"4";}
.vlr { writing-mode: vertical-lr; direction:rtl; }
.vrl { writing-mode: vertical-rl; direction:ltr; }
.hr abs3 { left:-24px; right:-37px; }
.vl abs3, .vr abs3, .vrl abs3, .vlr abs3 { left:-30px; top:-14px; right:-49px; }
.vr abs3, .vrl abs3 { left:-47px; right:-32px; }
.hr abs3 { left:-16px; right:-37px; }
.vl abs3, .vr abs3, .vrl abs3, .vlr abs3 { left:-30px; top:-14px; right:-41px; }
.vr abs3, .vrl abs3 { left:-39px; right:-32px; }
.vrl abs3 { top:-25px; }
.hl abs2, .hr abs2 { top:-25px; }
@ -76,7 +76,7 @@ abs4::before { content:"4";}
.hr abs4 { left:10px; }
.vl abs4, .vr abs4, .vrl abs4, .vlr abs4 { top:0px; bottom:-41px; left:-25px; }
.vr abs4, .vrl abs4 { left:68px; }
.vrl abs4 { top:-11px; bottom:-29px; }
.vrl abs4 { top:-11px; bottom:-30px; }
</style>

2
layout/reftests/css-grid/grid-abspos-items-015.html
Просмотреть файл

@ -21,7 +21,7 @@ separator { clear:both; display:block; height:6px; }
grid-template: 25px 33px 7px / 30px 51px 5px;
margin-right: 4px;
height: 100px;
width: 100px;
width: 92px;
}
.wrap {
position: relative;

2
layout/reftests/css-grid/grid-abspos-items-016.html
Просмотреть файл

@ -21,7 +21,7 @@ separator { clear:both; display:block; height:6px; }
grid-template: 25px 33px 7px / 30px 51px 5px;
margin-right: 4px;
height: 100px;
width: 100px;
width: 92px;
}
.wrap {
position: relative;