From a3c1002422e0766ce8726336b309cc8e36a561c0 Mon Sep 17 00:00:00 2001 From: Karl Tomlinson Date: Mon, 26 Jun 2023 21:52:50 +0000 Subject: [PATCH] Bug 1840313 fetch and remove the first element of queue in one operation r=emilio The two-step logic was left over from a previous std::queue implementation. https://hg.mozilla.org/mozilla-central/rev/4534179de22c013eb97e8226a538096d7a648721#l2.36 Depends on D181966 Differential Revision: https://phabricator.services.mozilla.com/D181967 --- xpcom/threads/TaskQueue.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xpcom/threads/TaskQueue.cpp b/xpcom/threads/TaskQueue.cpp index c0a50e7c6367..febb60978487 100644 --- a/xpcom/threads/TaskQueue.cpp +++ b/xpcom/threads/TaskQueue.cpp @@ -238,8 +238,7 @@ nsresult TaskQueue::Runner::Run() { mon.NotifyAll(); return NS_OK; } - event = std::move(mQueue->mTasks.FirstElement()); - mQueue->mTasks.Pop(); + event = mQueue->mTasks.Pop(); } MOZ_ASSERT(event.event);