Check hidden attribute when creating separators. r=saari/sr=sfraser. bug#151693

widget/src/mac/nsMenu.cpp

@@ -814,7 +814,7 @@ nsEventStatus nsMenu::MenuConstruct(
       if ( tag == nsWidgetAtoms::menuitem )
         LoadMenuItem(this, child);
       else if ( tag == nsWidgetAtoms::menuseparator )
-        AddSeparator();
+        LoadSeparator(child);
       else if ( tag == nsWidgetAtoms::menu )
         LoadSubMenu(this, child);
     }
@@ -1157,6 +1157,18 @@ nsMenu::LoadSubMenu( nsIMenu * pParentMenu, nsIContent* inMenuItemContent )
   }     
 }
 
+void
+nsMenu::LoadSeparator ( nsIContent* inMenuItemContent ) 
+{
+  // if item should be hidden, bail
+  nsAutoString hidden;
+  inMenuItemContent->GetAttr(kNameSpaceID_None, nsWidgetAtoms::hidden, hidden);
+  if ( hidden == NS_LITERAL_STRING("true") )
+    return;
+
+  AddSeparator();
+}
+
 
 //
 // OnCreate

widget/src/mac/nsMenu.h

@@ -160,6 +160,7 @@ protected:
   
   void LoadMenuItem ( nsIMenu* pParentMenu, nsIContent* menuitemContent);  
   void LoadSubMenu( nsIMenu * pParentMenu, nsIContent* menuitemContent);  
+  void LoadSeparator ( nsIContent* menuitemContent );
   nsEventStatus HelpMenuConstruct( const nsMenuEvent & aMenuEvent, nsIWidget* aParentWindow, 
                                     void* unused, void* aWebShell);