Bug 1617753 - Avoid using our DEBUG version of RemoveFrame() which is supposed to never be called. r=emilio

Differential Revision: https://phabricator.services.mozilla.com/D64206

--HG--
extra : moz-landing-system : lando

layout/forms/crashtests/1617753.html

@@ -0,0 +1,21 @@
+<style>
+    LEGEND, FORM {
+        white-space: pre-wrap;
+    }
+
+    LEGEND {
+        max-height: 0em;
+    }
+
+    FORM {
+        column-width: 1px;
+    }
+
+    FIELDSET {
+        column-width: 1em;
+    }
+</style>
+<form id="htmlvar00005" class="class3">
+    <fieldset>
+        <legend>
+            <!-- COMMENT -->

layout/forms/crashtests/crashtests.list

@@ -75,3 +75,4 @@ load 1471157.html
 load 1488219.html
 load 1600207.html
 load 1600367.html
+load 1617753.html

layout/forms/nsFieldSetFrame.cpp

@@ -887,7 +887,8 @@ void nsFieldSetFrame::EnsureChildContinuation(nsIFrame* aChild,
   nsIFrame* nif = aChild->GetNextInFlow();
   if (aStatus.IsFullyComplete()) {
     if (nif) {
-      RemoveFrame(kPrincipalList, nif);
+      // NOTE: we want to avoid our DEBUG version of RemoveFrame above.
+      nsContainerFrame::RemoveFrame(kNoReflowPrincipalList, nif);
       MOZ_ASSERT(!aChild->GetNextInFlow());
     }
   } else {