From a5e1b9471852652f7975e45a4bc90089243ae04e Mon Sep 17 00:00:00 2001 From: Ryan Hunt Date: Mon, 25 Feb 2019 16:13:15 -0600 Subject: [PATCH] Bug 1523969 part 24 - Move method definition inline comments to new line in 'tools/'. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D21125 --HG-- extra : rebase_source : 06b6b612faecb0beff2c359f8893e40638c4a029 extra : histedit_source : 69bbbe1c1cd598cc52103143baf6bbe4ff4b2d5b --- .../profiler/core/platform-linux-android.cpp | 3 ++- tools/profiler/core/platform-macos.cpp | 3 ++- tools/profiler/core/platform-win32.cpp | 3 ++- .../gecko/ChildProfilerController.cpp | 4 +-- tools/profiler/gecko/ProfilerParent.cpp | 26 ++++++++++++------- 5 files changed, 24 insertions(+), 15 deletions(-) diff --git a/tools/profiler/core/platform-linux-android.cpp b/tools/profiler/core/platform-linux-android.cpp index a8ae2938dc79..19d0a5c56d41 100644 --- a/tools/profiler/core/platform-linux-android.cpp +++ b/tools/profiler/core/platform-linux-android.cpp @@ -69,7 +69,8 @@ using namespace mozilla; -/* static */ int Thread::GetCurrentId() { return gettid(); } +/* static */ +int Thread::GetCurrentId() { return gettid(); } void* GetStackTop(void* aGuess) { return aGuess; } diff --git a/tools/profiler/core/platform-macos.cpp b/tools/profiler/core/platform-macos.cpp index aea7332974c1..b023dc2ea486 100644 --- a/tools/profiler/core/platform-macos.cpp +++ b/tools/profiler/core/platform-macos.cpp @@ -32,7 +32,8 @@ // this port is based off of v8 svn revision 9837 -/* static */ int Thread::GetCurrentId() { return gettid(); } +/* static */ +int Thread::GetCurrentId() { return gettid(); } void* GetStackTop(void* aGuess) { pthread_t thread = pthread_self(); diff --git a/tools/profiler/core/platform-win32.cpp b/tools/profiler/core/platform-win32.cpp index 7b533b7c33dd..931dc968ba08 100644 --- a/tools/profiler/core/platform-win32.cpp +++ b/tools/profiler/core/platform-win32.cpp @@ -36,7 +36,8 @@ #include "mozilla/StackWalk_windows.h" #include "mozilla/WindowsVersion.h" -/* static */ int Thread::GetCurrentId() { +/* static */ +int Thread::GetCurrentId() { DWORD threadId = GetCurrentThreadId(); MOZ_ASSERT(threadId <= INT32_MAX, "native thread ID is > INT32_MAX"); return int(threadId); diff --git a/tools/profiler/gecko/ChildProfilerController.cpp b/tools/profiler/gecko/ChildProfilerController.cpp index 444f64aa0343..0f27e947ba02 100644 --- a/tools/profiler/gecko/ChildProfilerController.cpp +++ b/tools/profiler/gecko/ChildProfilerController.cpp @@ -14,8 +14,8 @@ using namespace mozilla::ipc; namespace mozilla { -/* static */ already_AddRefed -ChildProfilerController::Create( +/* static */ +already_AddRefed ChildProfilerController::Create( mozilla::ipc::Endpoint&& aEndpoint) { MOZ_RELEASE_ASSERT(NS_IsMainThread()); RefPtr cpc = new ChildProfilerController(); diff --git a/tools/profiler/gecko/ProfilerParent.cpp b/tools/profiler/gecko/ProfilerParent.cpp index b3eed2c2ba69..2d968fd9bc3b 100644 --- a/tools/profiler/gecko/ProfilerParent.cpp +++ b/tools/profiler/gecko/ProfilerParent.cpp @@ -36,8 +36,8 @@ class ProfilerParentTracker final { UniquePtr ProfilerParentTracker::sInstance; -/* static */ void ProfilerParentTracker::StartTracking( - ProfilerParent* aProfilerParent) { +/* static */ +void ProfilerParentTracker::StartTracking(ProfilerParent* aProfilerParent) { if (!sInstance) { sInstance = MakeUnique(); ClearOnShutdown(&sInstance); @@ -45,14 +45,16 @@ UniquePtr ProfilerParentTracker::sInstance; sInstance->mProfilerParents.AppendElement(aProfilerParent); } -/* static */ void ProfilerParentTracker::StopTracking(ProfilerParent* aParent) { +/* static */ +void ProfilerParentTracker::StopTracking(ProfilerParent* aParent) { if (sInstance) { sInstance->mProfilerParents.RemoveElement(aParent); } } template -/* static */ void ProfilerParentTracker::Enumerate(FuncType aIterFunc) { +/* static */ +void ProfilerParentTracker::Enumerate(FuncType aIterFunc) { if (sInstance) { for (ProfilerParent* profilerParent : sInstance->mProfilerParents) { if (!profilerParent->mDestroyed) { @@ -82,7 +84,8 @@ ProfilerParentTracker::~ProfilerParentTracker() { } } -/* static */ Endpoint ProfilerParent::CreateForProcess( +/* static */ +Endpoint ProfilerParent::CreateForProcess( base::ProcessId aOtherPid) { MOZ_RELEASE_ASSERT(NS_IsMainThread()); Endpoint parent; @@ -173,8 +176,8 @@ ProfilerParent::GatherProfiles() { return results; } -/* static */ void ProfilerParent::ProfilerStarted( - nsIProfilerStartParams* aParams) { +/* static */ +void ProfilerParent::ProfilerStarted(nsIProfilerStartParams* aParams) { if (!NS_IsMainThread()) { return; } @@ -198,7 +201,8 @@ ProfilerParent::GatherProfiles() { }); } -/* static */ void ProfilerParent::ProfilerStopped() { +/* static */ +void ProfilerParent::ProfilerStopped() { if (!NS_IsMainThread()) { return; } @@ -208,7 +212,8 @@ ProfilerParent::GatherProfiles() { }); } -/* static */ void ProfilerParent::ProfilerPaused() { +/* static */ +void ProfilerParent::ProfilerPaused() { if (!NS_IsMainThread()) { return; } @@ -218,7 +223,8 @@ ProfilerParent::GatherProfiles() { }); } -/* static */ void ProfilerParent::ProfilerResumed() { +/* static */ +void ProfilerParent::ProfilerResumed() { if (!NS_IsMainThread()) { return; }