Bug 1358709 - Part 2: Remove the SlowScriptData.lineno IPDL field and the glue code; r=bill

This commit is contained in:
Ehsan Akhgari 2017-04-22 01:27:10 -04:00
Родитель 561daa3a09
Коммит a628d03be7
4 изменённых файлов: 12 добавлений и 20 удалений

Просмотреть файл

@ -11579,8 +11579,7 @@ nsGlobalWindow::ShowSlowScriptDialog()
nsIDocShell* docShell = GetDocShell();
nsCOMPtr<nsITabChild> child = docShell ? docShell->GetTabChild() : nullptr;
action = monitor->NotifySlowScript(child,
filename.get(),
lineno);
filename.get());
if (action == ProcessHangMonitor::Terminate) {
return KillSlowScript;
}

Просмотреть файл

@ -14,7 +14,6 @@ struct SlowScriptData
{
TabId tabId;
nsCString filename;
uint32_t lineno;
};
struct PluginHangData

Просмотреть файл

@ -85,11 +85,9 @@ class HangMonitorChild
typedef ProcessHangMonitor::SlowScriptAction SlowScriptAction;
SlowScriptAction NotifySlowScript(nsITabChild* aTabChild,
const char* aFileName,
unsigned aLineNo);
const char* aFileName);
void NotifySlowScriptAsync(TabId aTabId,
const nsCString& aFileName,
unsigned aLineNo);
const nsCString& aFileName);
bool IsDebuggerStartupComplete();
@ -457,18 +455,16 @@ HangMonitorChild::Bind(Endpoint<PProcessHangMonitorChild>&& aEndpoint)
void
HangMonitorChild::NotifySlowScriptAsync(TabId aTabId,
const nsCString& aFileName,
unsigned aLineNo)
const nsCString& aFileName)
{
if (mIPCOpen) {
Unused << SendHangEvidence(SlowScriptData(aTabId, aFileName, aLineNo));
Unused << SendHangEvidence(SlowScriptData(aTabId, aFileName));
}
}
HangMonitorChild::SlowScriptAction
HangMonitorChild::NotifySlowScript(nsITabChild* aTabChild,
const char* aFileName,
unsigned aLineNo)
const char* aFileName)
{
MOZ_RELEASE_ASSERT(NS_IsMainThread());
@ -496,9 +492,9 @@ HangMonitorChild::NotifySlowScript(nsITabChild* aTabChild,
nsAutoCString filename(aFileName);
MonitorLoop()->PostTask(NewNonOwningRunnableMethod
<TabId, nsCString, unsigned>(this,
&HangMonitorChild::NotifySlowScriptAsync,
id, filename, aLineNo));
<TabId, nsCString>(this,
&HangMonitorChild::NotifySlowScriptAsync,
id, filename));
return SlowScriptAction::Continue;
}
@ -1169,11 +1165,10 @@ ProcessHangMonitor::Observe(nsISupports* aSubject, const char* aTopic, const cha
ProcessHangMonitor::SlowScriptAction
ProcessHangMonitor::NotifySlowScript(nsITabChild* aTabChild,
const char* aFileName,
unsigned aLineNo)
const char* aFileName)
{
MOZ_RELEASE_ASSERT(NS_IsMainThread());
return HangMonitorChild::Get()->NotifySlowScript(aTabChild, aFileName, aLineNo);
return HangMonitorChild::Get()->NotifySlowScript(aTabChild, aFileName);
}
bool

Просмотреть файл

@ -57,8 +57,7 @@ class ProcessHangMonitor final
StartDebugger
};
SlowScriptAction NotifySlowScript(nsITabChild* aTabChild,
const char* aFileName,
unsigned aLineNo);
const char* aFileName);
void NotifyPluginHang(uint32_t aPluginId);