From a6578c65f6b404043a8c5cba5f047ec42832dde4 Mon Sep 17 00:00:00 2001 From: Andrew Osmond Date: Tue, 7 Nov 2017 06:42:47 -0500 Subject: [PATCH] Bug 1414762 - imgRequestProxy::CancelAndForgetObserver should always force load group removal to dispatch. r=tnikkel imgRequestProxy::CancelAndForgetObserver was intended to always dispatch any load group removals due to reentracy conflicts with the callers. However in bug 1404422 the fact that imgRequest::RemoveProxy can indirectly trigger a load group removal through completing an incompleted request. --- image/imgRequestProxy.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/image/imgRequestProxy.cpp b/image/imgRequestProxy.cpp index 008bbcfb9315..a1d19b37e495 100644 --- a/image/imgRequestProxy.cpp +++ b/image/imgRequestProxy.cpp @@ -515,12 +515,12 @@ imgRequestProxy::CancelAndForgetObserver(nsresult aStatus) LOG_SCOPE(gImgLog, "imgRequestProxy::CancelAndForgetObserver"); mCanceled = true; + mForceDispatchLoadGroup = true; if (GetOwner()) { GetOwner()->RemoveProxy(this, aStatus); } - mForceDispatchLoadGroup = true; RemoveFromLoadGroup(); mForceDispatchLoadGroup = false;