Bug 1061248 - Fix some bad implicit constructors in LUL; r=BenWa

This commit is contained in:
Ehsan Akhgari 2014-09-02 09:45:28 -04:00
Родитель 66e1349be9
Коммит a725e9f55f
4 изменённых файлов: 6 добавлений и 6 удалений

Просмотреть файл

@ -72,7 +72,7 @@ Module::~Module() {
// //
class UniqueString { class UniqueString {
public: public:
UniqueString(string str) { str_ = strdup(str.c_str()); } explicit UniqueString(string str) { str_ = strdup(str.c_str()); }
~UniqueString() { free(reinterpret_cast<void*>(const_cast<char*>(str_))); } ~UniqueString() { free(reinterpret_cast<void*>(const_cast<char*>(str_))); }
const char* str_; const char* str_;
}; };

Просмотреть файл

@ -490,7 +490,7 @@ class SegArray {
class PriMap { class PriMap {
public: public:
PriMap(void (*aLog)(const char*)) explicit PriMap(void (*aLog)(const char*))
: mLog(aLog) : mLog(aLog)
{} {}
@ -838,7 +838,7 @@ class PriMap {
class CFICache { class CFICache {
public: public:
CFICache(PriMap* aPriMap) { explicit CFICache(PriMap* aPriMap) {
Invalidate(); Invalidate();
mPriMap = aPriMap; mPriMap = aPriMap;
} }

Просмотреть файл

@ -60,7 +60,7 @@ namespace lul {
class TaggedUWord { class TaggedUWord {
public: public:
// Construct a valid one. // Construct a valid one.
TaggedUWord(uintptr_t w) explicit TaggedUWord(uintptr_t w)
: mValue(w) : mValue(w)
, mValid(true) , mValid(true)
{} {}
@ -165,7 +165,7 @@ class CFICache;
class LUL { class LUL {
public: public:
// Create; supply a logging sink. Initialises the rw-lock. // Create; supply a logging sink. Initialises the rw-lock.
LUL(void (*aLog)(const char*)); explicit LUL(void (*aLog)(const char*));
// Destroy. This acquires mRWlock for writing. By doing that, waits // Destroy. This acquires mRWlock for writing. By doing that, waits
// for all unwinder threads to finish any Unwind() calls they may be // for all unwinder threads to finish any Unwind() calls they may be

Просмотреть файл

@ -223,7 +223,7 @@ public:
// so let's use mSummaryMinAddr == 1 and mSummaryMaxAddr == 0 to denote // so let's use mSummaryMinAddr == 1 and mSummaryMaxAddr == 0 to denote
// this case. // this case.
SecMap(void(*aLog)(const char*)); explicit SecMap(void(*aLog)(const char*));
~SecMap(); ~SecMap();
// Binary search mRuleSets to find one that brackets |ia|, or nullptr // Binary search mRuleSets to find one that brackets |ia|, or nullptr