From a7d35e9f6b454984c23df63e19f050083f13ba57 Mon Sep 17 00:00:00 2001 From: Ting-Yu Chou Date: Fri, 22 Jul 2016 09:35:22 +0800 Subject: [PATCH] Bug 1278505 - Remove unneeded NS_NOTREACHED from DeallocPPrintProgressDialogChild(). r=mconley MozReview-Commit-ID: 7WvZM390h8W --HG-- extra : transplant_source : %7B%C6%26%18%C8i%20U%165%A9%90%F2%13%7B%16%AC%3D4%8A --- embedding/components/printingui/ipc/nsPrintingProxy.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/embedding/components/printingui/ipc/nsPrintingProxy.cpp b/embedding/components/printingui/ipc/nsPrintingProxy.cpp index 8fed6ed83136..4a7545dfacfe 100644 --- a/embedding/components/printingui/ipc/nsPrintingProxy.cpp +++ b/embedding/components/printingui/ipc/nsPrintingProxy.cpp @@ -226,11 +226,9 @@ nsPrintingProxy::AllocPPrintProgressDialogChild() bool nsPrintingProxy::DeallocPPrintProgressDialogChild(PPrintProgressDialogChild* aActor) { - // The parent process will never initiate the PPrintProgressDialog - // protocol connection, so no need to provide an deallocator here. - NS_NOTREACHED("Deallocator for PPrintProgressDialogChild should not be " - "called on nsPrintingProxy."); - return false; + // The PrintProgressDialogChild implements refcounting, and + // will take itself out. + return true; } PPrintSettingsDialogChild*