From a85265140edddf0fb87fde8d2dcc30724c267399 Mon Sep 17 00:00:00 2001
From: Sylvestre Ledru <sledru@mozilla.com>
Date: Fri, 4 Aug 2017 11:35:33 +0200
Subject: [PATCH] Bug 1387376 - Reserve memory before using push_back with
 vector r=nical

MozReview-Commit-ID: BOyPShEVfzt

--HG--
extra : rebase_source : 2564c80f5ac593927d9b104199e0b747f9ab887b
---
 gfx/tests/gtest/TestTreeTraversal.cpp | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gfx/tests/gtest/TestTreeTraversal.cpp b/gfx/tests/gtest/TestTreeTraversal.cpp
index fe5b6c555a2d..a16de9d6066a 100644
--- a/gfx/tests/gtest/TestTreeTraversal.cpp
+++ b/gfx/tests/gtest/TestTreeTraversal.cpp
@@ -286,6 +286,7 @@ TEST(TreeTraversal, DepthFirstSearchValueExists)
   size_t expectedNeedleTraversalRank = 7;
   RefPtr<SearchTestNodeForward> needleNode;
   std::vector<RefPtr<SearchTestNodeForward>> nodeList;
+  nodeList.reserve(10);
   for (size_t i = 0; i < 10; i++)
   {
     if (i == expectedNeedleTraversalRank) {
@@ -335,6 +336,7 @@ TEST(TreeTraversal, DepthFirstSearchValueExistsReverse)
   size_t expectedNeedleTraversalRank = 7;
   RefPtr<SearchTestNodeReverse> needleNode;
   std::vector<RefPtr<SearchTestNodeReverse>> nodeList;
+  nodeList.reserve(10);
   for (size_t i = 0; i < 10; i++)
   {
     if (i == expectedNeedleTraversalRank) {
@@ -406,6 +408,7 @@ TEST(TreeTraversal, DepthFirstSearchValueDoesNotExist)
 {
   int visitCount = 0;
   std::vector<RefPtr<SearchTestNodeForward>> nodeList;
+  nodeList.reserve(10);
   for (int i = 0; i < 10; i++)
   {
       nodeList.push_back(new SearchTestNodeForward(SearchNodeType::Hay, i));
@@ -446,6 +449,7 @@ TEST(TreeTraversal, DepthFirstSearchValueDoesNotExistReverse)
 {
   int visitCount = 0;
   std::vector<RefPtr<SearchTestNodeReverse>> nodeList;
+  nodeList.reserve(10);
   for (int i = 0; i < 10; i++)
   {
       nodeList.push_back(new SearchTestNodeReverse(SearchNodeType::Hay, i));
@@ -619,6 +623,7 @@ TEST(TreeTraversal, DepthFirstSearchPostOrderValueDoesNotExist)
 {
   int visitCount = 0;
   std::vector<RefPtr<SearchTestNodeForward>> nodeList;
+  nodeList.reserve(10);
   for (int i = 0; i < 10; i++)
   {
       nodeList.push_back(new SearchTestNodeForward(SearchNodeType::Hay, i));
@@ -658,6 +663,7 @@ TEST(TreeTraversal, DepthFirstSearchPostOrderValueDoesNotExistReverse)
 {
   int visitCount = 0;
   std::vector<RefPtr<SearchTestNodeReverse>> nodeList;
+  nodeList.reserve(10);
   for (int i = 0; i < 10; i++)
   {
       nodeList.push_back(new SearchTestNodeReverse(SearchNodeType::Hay, i));
@@ -734,6 +740,7 @@ TEST(TreeTraversal, BreadthFirstSearchValueExists)
   size_t expectedNeedleTraversalRank = 7;
   RefPtr<SearchTestNodeForward> needleNode;
   std::vector<RefPtr<SearchTestNodeForward>> nodeList;
+  nodeList.reserve(10);
   for (size_t i = 0; i < 10; i++)
   {
     if (i == expectedNeedleTraversalRank) {
@@ -783,6 +790,7 @@ TEST(TreeTraversal, BreadthFirstSearchValueExistsReverse)
   size_t expectedNeedleTraversalRank = 7;
   RefPtr<SearchTestNodeReverse> needleNode;
   std::vector<RefPtr<SearchTestNodeReverse>> nodeList;
+  nodeList.reserve(10);
   for (size_t i = 0; i < 10; i++)
   {
     if (i == expectedNeedleTraversalRank) {
@@ -830,6 +838,7 @@ TEST(TreeTraversal, BreadthFirstSearchValueDoesNotExist)
 {
   int visitCount = 0;
   std::vector<RefPtr<SearchTestNodeForward>> nodeList;
+  nodeList.reserve(10);
   for (int i = 0; i < 10; i++)
   {
     nodeList.push_back(new SearchTestNodeForward(SearchNodeType::Hay, i));
@@ -870,6 +879,7 @@ TEST(TreeTraversal, BreadthFirstSearchValueDoesNotExistReverse)
 {
   int visitCount = 0;
   std::vector<RefPtr<SearchTestNodeReverse>> nodeList;
+  nodeList.reserve(10);
   for (int i = 0; i < 10; i++)
   {
     nodeList.push_back(new SearchTestNodeReverse(SearchNodeType::Hay, i));
@@ -920,6 +930,7 @@ TEST(TreeTraversal, ForEachNodeAllEligible)
 {
   std::vector<RefPtr<ForEachTestNodeForward>> nodeList;
   int visitCount = 0;
+  nodeList.reserve(10);
   for (int i = 0; i < 10; i++)
   {
     nodeList.push_back(new ForEachTestNodeForward(ForEachNodeType::Continue,i));
@@ -958,6 +969,7 @@ TEST(TreeTraversal, ForEachNodeAllEligibleReverse)
 {
   std::vector<RefPtr<ForEachTestNodeReverse>> nodeList;
   int visitCount = 0;
+  nodeList.reserve(10);
   for (int i = 0; i < 10; i++)
   {
     nodeList.push_back(new ForEachTestNodeReverse(ForEachNodeType::Continue,i));
@@ -1119,6 +1131,7 @@ TEST(TreeTraversal, ForEachNodeLeavesIneligible)
 {
 
   std::vector<RefPtr<ForEachTestNodeForward>> nodeList;
+  nodeList.reserve(10);
   int visitCount = 0;
   for (int i = 0; i < 10; i++)
   {
@@ -1161,6 +1174,7 @@ TEST(TreeTraversal, ForEachNodeLeavesIneligibleReverse)
 {
 
   std::vector<RefPtr<ForEachTestNodeReverse>> nodeList;
+  nodeList.reserve(10);
   int visitCount = 0;
   for (int i = 0; i < 10; i++)
   {
@@ -1202,6 +1216,7 @@ TEST(TreeTraversal, ForEachNodeLeavesIneligibleReverse)
 TEST(TreeTraversal, ForEachNodeLambdaReturnsVoid)
 {
   std::vector<RefPtr<ForEachTestNodeReverse>> nodeList;
+  nodeList.reserve(10);
   int visitCount = 0;
   for (int i = 0; i < 10; i++)
   {