From a858271ee653a36c1abfa91278367c9a4f18597a Mon Sep 17 00:00:00 2001 From: Valentin Gosu Date: Tue, 18 Apr 2017 14:17:58 +0800 Subject: [PATCH] Bug 1354349 - Use channel.isDocument in ContentParent::TransmitPermissionsFor r=mystor MozReview-Commit-ID: L9b6UeXJ8o5 --HG-- extra : rebase_source : a03d4f34bc53a92056168302c8ef41fb277db0ee --- dom/ipc/ContentParent.cpp | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/dom/ipc/ContentParent.cpp b/dom/ipc/ContentParent.cpp index 4cdcb93dc20e..38e43058ecb3 100644 --- a/dom/ipc/ContentParent.cpp +++ b/dom/ipc/ContentParent.cpp @@ -5035,27 +5035,10 @@ ContentParent::TransmitPermissionsFor(nsIChannel* aChannel) { MOZ_ASSERT(aChannel); #ifdef MOZ_PERMISSIONS - // Check if this channel is going to be used to create a document. If it has - // LOAD_DOCUMENT_URI set it is trivially creating a document. If - // LOAD_HTML_OBJECT_DATA is set it may or may not be used to create a - // document, depending on its MIME type. - nsLoadFlags loadFlags; - nsresult rv = aChannel->GetLoadFlags(&loadFlags); - NS_ENSURE_SUCCESS(rv, rv); - if (!(loadFlags & nsIChannel::LOAD_DOCUMENT_URI)) { - if (loadFlags & nsIRequest::LOAD_HTML_OBJECT_DATA) { - nsAutoCString mimeType; - aChannel->GetContentType(mimeType); - if (nsContentUtils::HtmlObjectContentTypeForMIMEType(mimeType, nullptr) != - nsIObjectLoadingContent::TYPE_DOCUMENT) { - // The MIME type would not cause the creation of a document - return NS_OK; - } - } else { - // neither flag was set - return NS_OK; - } + nsresult rv; + if (!aChannel->IsDocument()) { + return NS_OK; } // Get the principal for the channel result, so that we can get the permission