From a8f93d6c2fee129f342c860dc77c5f9fb2eddf6a Mon Sep 17 00:00:00 2001 From: Ehsan Akhgari Date: Mon, 25 Feb 2013 20:59:33 -0500 Subject: [PATCH] Bug 844169 - Part 2: Rename nsIDOMHTMLIFrameElement.allowfullscreen to allowFullscreen in order to comply with the spec; r=cpearce --- browser/base/content/test/test_contextmenu.html | 2 +- content/html/content/src/HTMLIFrameElement.cpp | 2 +- content/html/content/test/file_fullscreen-api.html | 2 +- dom/interfaces/html/nsIDOMHTMLIFrameElement.idl | 9 +++------ 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/browser/base/content/test/test_contextmenu.html b/browser/base/content/test/test_contextmenu.html index a91311f1b850..b5cce6574579 100644 --- a/browser/base/content/test/test_contextmenu.html +++ b/browser/base/content/test/test_contextmenu.html @@ -953,7 +953,7 @@ function startTest() { return; } - subwindow.allowfullscreen = true; + subwindow.allowFullscreen = true; lastElement = null; text = subwindow.document.getElementById("test-text"); diff --git a/content/html/content/src/HTMLIFrameElement.cpp b/content/html/content/src/HTMLIFrameElement.cpp index 81b0afa65fc7..3e8aa480641e 100644 --- a/content/html/content/src/HTMLIFrameElement.cpp +++ b/content/html/content/src/HTMLIFrameElement.cpp @@ -56,7 +56,7 @@ NS_IMPL_STRING_ATTR(HTMLIFrameElement, Name, name) NS_IMPL_STRING_ATTR(HTMLIFrameElement, Scrolling, scrolling) NS_IMPL_URI_ATTR(HTMLIFrameElement, Src, src) NS_IMPL_STRING_ATTR(HTMLIFrameElement, Width, width) -NS_IMPL_BOOL_ATTR(HTMLIFrameElement, Allowfullscreen, allowfullscreen) +NS_IMPL_BOOL_ATTR(HTMLIFrameElement, AllowFullscreen, allowfullscreen) NS_IMPL_STRING_ATTR(HTMLIFrameElement, Sandbox, sandbox) void diff --git a/content/html/content/test/file_fullscreen-api.html b/content/html/content/test/file_fullscreen-api.html index 931ef026811c..0bff1f69274c 100644 --- a/content/html/content/test/file_fullscreen-api.html +++ b/content/html/content/test/file_fullscreen-api.html @@ -78,7 +78,7 @@ function exit1(event) { is(event.target, document, "10. Event target should be full-screen document #2"); is(document.mozFullScreenElement, null, "11. Full-screen element should be null."); iframe = document.createElement("iframe"); - iframe.allowfullscreen = true; + iframe.allowFullscreen = true; addFullscreenChangeContinuation("enter", enter2); document.body.appendChild(iframe); iframe.src = iframeContents; diff --git a/dom/interfaces/html/nsIDOMHTMLIFrameElement.idl b/dom/interfaces/html/nsIDOMHTMLIFrameElement.idl index 719da91062b7..75d126ff36a6 100644 --- a/dom/interfaces/html/nsIDOMHTMLIFrameElement.idl +++ b/dom/interfaces/html/nsIDOMHTMLIFrameElement.idl @@ -16,7 +16,7 @@ * http://www.whatwg.org/specs/web-apps/current-work/ */ -[scriptable, uuid(a7bd1e34-3969-47ae-8c1d-2970132ba925)] +[scriptable, uuid(39298082-9657-48be-b119-4dc9c84ce685)] interface nsIDOMHTMLIFrameElement : nsIDOMHTMLElement { attribute DOMString align; @@ -34,9 +34,6 @@ interface nsIDOMHTMLIFrameElement : nsIDOMHTMLElement readonly attribute nsIDOMWindow contentWindow; attribute DOMString sandbox; - // Mozilla extensions - // iframe elements require the allowfullscreen attribute to be present - // if they're to allow content in the sub document to go into DOM full-screen - // mode. See https://wiki.mozilla.org/index.php?title=Gecko:FullScreenAPI - attribute boolean allowfullscreen; + + attribute boolean allowFullscreen; };