bug 436077 - Preferences: review comments

mobile/chrome/content/browser-ui.js

@@ -592,7 +592,6 @@ var BrowserUI = {
     var bookmark = document.getElementById("bookmark-container");
     var urllist = document.getElementById("urllist-container");
     var container = document.getElementById("browser-container");
-    var prefs = document.getElementById("pref-pane");
 
     if (aMode == UIMODE_URLVIEW)
     {

mobile/chrome/content/browser.css

@@ -10,7 +10,7 @@ richlistitem[type="documenttab"] {
     -moz-binding: url("chrome://browser/content/deckbrowser.xml#documenttab");
 }
 
-#pref-pane > scrollbox
+#prefs-container > scrollbox
 {
     overflow: auto;
 }

mobile/chrome/content/browser.xul

@@ -40,7 +40,6 @@
 
 <?xml-stylesheet href="chrome://browser/skin/browser.css" type="text/css"?>
 <?xml-stylesheet href="chrome://browser/content/browser.css" type="text/css"?>
-<?xml-stylesheet href="chrome://browser/skin/richpref.css" type="text/css"?>
 
 <!DOCTYPE window [
 <!ENTITY % browserDTD SYSTEM "chrome://browser/locale/browser.dtd">
@@ -240,7 +239,7 @@
         <iframe id="addons-container" flex="1" src=""/>
         <iframe id="downloads-container" flex="1" src=""/>
 
-        <vbox id="pref-pane">
+        <vbox id="prefs-container">
           <hbox pack="center" id="buttons"/>
           <scrollbox orient="vertical" id="pref-list" seltype="single" flex="1">
             <vbox class="prefsection">

mobile/chrome/jar.mn

@@ -52,7 +52,6 @@ classic.jar:
   images/right_sidebar_middle.png      (skin/images/right_sidebar_middle.png)
   images/right_sidebar_bottom.png      (skin/images/right_sidebar_bottom.png)
   images/right_buttons.png             (skin/images/right_buttons.png)
-  richpref.css                         (skin/richpref.css)
 
 @AB_CD@.jar:
 % locale browser @AB_CD@ %

mobile/chrome/skin/browser.css

@@ -544,3 +544,46 @@ findbar {
   min-width: 280px;
   padding: 10px;
 }
+
+/* Preferences window */
+#prefs-container
+{
+  background-color: rgba(123,125,123,0.9);
+}
+
+richpref
+{
+  background-color: white;
+}
+
+.prefsection
+{
+  font-size: 1.5em ! important;
+  color: white;
+  background-color: grey;
+  padding: .2em 0 .2em 0;
+}
+
+.prefbox
+{
+  padding: .3em .3em .3em .5em;
+  border: thin solid lightgrey;
+}
+
+.preftitle
+{
+  font-size: 1.25em ! important;
+}
+
+.prefdesc
+{
+  font-size: 1em ! important;
+  color: grey;
+  background-color: white;
+}
+
+/* BUG: This rule doesn't actually work; I don't know why. */
+richpref > button
+{
+  font-size: 1em ! important;
+}

mobile/chrome/skin/richpref.css

@@ -1,41 +0,0 @@
-#pref-pane
-{
-  background-color: rgba(123,125,123,0.9);
-}
-
-richpref
-{
-  background-color: white;
-}
-
-.prefsection
-{
-  font-size: 1.5em ! important;
-  color: white;
-  background-color: grey;
-  padding: .2em 0 .2em 0;
-}
-
-.prefbox
-{
-  padding: .3em .3em .3em .5em;
-  border: thin solid lightgrey;
-}
-
-.preftitle
-{
-  font-size: 1.25em ! important;
-}
-
-.prefdesc
-{
-  font-size: 1em ! important;
-  color: grey;
-  background-color: white;
-}
-
-/* BUG: This rule doesn't actually work; I don't know why. */
-richpref > button
-{
-  font-size: 1em ! important;
-}