From aa235fb2a476ed9ab04eae8c83a82f50e2768188 Mon Sep 17 00:00:00 2001 From: Maxime Villard Date: Fri, 15 Nov 2013 21:46:37 -0500 Subject: [PATCH] Bug 835029 - Fix off-by-one error in readlink call. r=briansmith --- .../src/client/solaris/handler/minidump_generator.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolkit/crashreporter/google-breakpad/src/client/solaris/handler/minidump_generator.cc b/toolkit/crashreporter/google-breakpad/src/client/solaris/handler/minidump_generator.cc index 7485025fe45f..fcf0dc751d97 100644 --- a/toolkit/crashreporter/google-breakpad/src/client/solaris/handler/minidump_generator.cc +++ b/toolkit/crashreporter/google-breakpad/src/client/solaris/handler/minidump_generator.cc @@ -511,7 +511,7 @@ bool ModuleInfoCallback(const ModuleInfo &module_info, void *context) { int count; snprintf(path, sizeof (path), "/proc/self/path/%s", module_info.name); - if ((count = readlink(path, buf, PATH_MAX)) < 0) + if ((count = readlink(path, buf, PATH_MAX - 1)) < 0) return false; buf[count] = '\0';