Bug 1618885 - Remove unused is_fennec. r=jmaher,geckoview-reviewers,extension-reviewers,credential-management-reviewers,sgalich,robwu,calu

is_fennec is unused now, let's remove it.

Differential Revision: https://phabricator.services.mozilla.com/D170849

docshell/test/mochitest/mochitest.ini

@@ -78,7 +78,7 @@ support-files = file_bug511449.html
 [test_bug530396.html]
 support-files = bug530396-noref.sjs bug530396-subframe.html
 [test_bug540462.html]
-skip-if = toolkit == 'android' && debug && !is_fennec
+skip-if = toolkit == 'android' && debug
 [test_bug551225.html]
 [test_bug570341.html]
 skip-if = (verify && !debug && (os == 'win'))

dom/base/test/mochitest.ini

@@ -650,7 +650,7 @@ skip-if = !sessionHistoryInParent
 [test_domparsing.html]
 [test_domrequest.html]
 [test_domwindowutils.html]
-skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
+skip-if = toolkit == 'android' # Bug 1525959
 [test_element.matches.html]
 [test_element_closest.html]
 [test_elementTraversal.html]
@@ -961,7 +961,7 @@ support-files = file_window_focus_by_close_and_open.html
 [test_writable-replaceable.html]
 [test_x-frame-options.html]
 skip-if =
-    toolkit == 'android' && debug && !is_fennec
+    toolkit == 'android' && debug
     xorigin  # JavaScript error: http://mochi.test:8888/tests/dom/base/test/test_x-frame-options.html, line 48: TypeError: can't access property "textContent", this.content.document.getElementById(...) is null, JavaScript error: resource://gre/modules/ProcessSelector.jsm, line 56: TypeError: can't access property "tabCount", process is null
 [test_youtube_flash_embed.html]
 # Please keep alphabetical order.

dom/html/test/mochitest.ini

@@ -258,7 +258,7 @@ skip-if = toolkit == 'android' #TIMED_OUT
 [test_bug424698.html]
 [test_bug428135.xhtml]
 [test_bug430351.html]
-skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
+skip-if = toolkit == 'android' # Bug 1525959
 [test_bug441930.html]
 [test_bug442801.html]
 [test_bug448166.html]
@@ -388,7 +388,7 @@ support-files =
 [test_bug691.html]
 [test_bug694.html]
 [test_bug694503.html]
-skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
+skip-if = toolkit == 'android' # Bug 1525959
 [test_bug696.html]
 [test_bug717819.html]
 [test_bug742030.html]
@@ -535,7 +535,7 @@ support-files = file_bug871161-1.html file_bug871161-2.html
 [test_bug1013316.html]
 [test_window_open_close.html]
 tags = openwindow
-skip-if = (toolkit == "android" && debug && !is_fennec) || (os == "linux") || (os == "win" && debug && bits == 64) # Bug 1533759
+skip-if = (toolkit == "android" && debug) || (os == "linux") || (os == "win" && debug && bits == 64) # Bug 1533759
 [test_viewport_resize.html]
 [test_image_clone_load.html]
 [test_bug1203668.html]

dom/indexedDB/test/mochitest.ini

@@ -168,9 +168,9 @@ skip-if = verify
 [test_file_put_get_values.html]
 [test_file_replace.html]
 [test_file_resurrection_delete.html]
-skip-if = toolkit == 'android' && !is_fennec
+skip-if = toolkit == 'android'
 [test_file_resurrection_transaction_abort.html]
-skip-if = toolkit == 'android' && !is_fennec
+skip-if = toolkit == 'android'
 [test_file_sharing.html]
 [test_file_transaction_abort.html]
 [test_getAll.html]

dom/notification/test/mochitest/mochitest.ini

@@ -5,7 +5,7 @@ support-files =
   create_notification.html
   MockServices.js
   NotificationTest.js
-skip-if = toolkit == 'android' && !is_fennec # Bug 1531097
+skip-if = toolkit == 'android' # Bug 1531097
 
 [test_notification_basics.html]
 skip-if = xorigin # Bug 1792790

dom/performance/tests/mochitest.ini

@@ -29,9 +29,9 @@ support-files =
 skip-if = true # Bug 1571904
 [test_worker_performance_now.html]
 [test_timeOrigin.html]
-skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
+skip-if = toolkit == 'android' # Bug 1525959
 [test_worker_performance_entries.html]
-skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
+skip-if = toolkit == 'android' # Bug 1525959
 [test_performance_timing_json.html]
 [test_performance_server_timing.html]
 scheme = https

dom/serviceworkers/test/mochitest-common.ini

@@ -268,9 +268,9 @@ skip-if = xorigin # JavaScript error: http://mochi.xorigin-test:8888/tests/Simpl
 [test_match_all.html]
 [test_match_all_advanced.html]
 [test_match_all_client_id.html]
-skip-if = toolkit == 'android' && !is_fennec
+skip-if = toolkit == 'android'
 [test_match_all_client_properties.html]
-skip-if = toolkit == 'android' && !is_fennec
+skip-if = toolkit == 'android'
 [test_navigationPreload_disable_crash.html]
 scheme = https
 skip-if =
@@ -283,7 +283,7 @@ skip-if = serviceworker_e10s # leaks InterceptedHttpChannel and others things
 skip-if = xorigin # Bug 1792790
 [test_notification_openWindow.html]
 skip-if =
-    toolkit == 'android' && !is_fennec  # Bug 1620052
+    toolkit == 'android'  # Bug 1620052
     xorigin  # JavaScript error: http://mochi.xorigin-test:8888/tests/SimpleTest/TestRunner.js, line 157: SecurityError: Permission denied to access property "wrappedJSObject" on cross-origin object
 support-files = notification_openWindow_worker.js file_notification_openWindow.html
 tags = openwindow
@@ -340,4 +340,4 @@ skip-if = toolkit == 'android' #Bug 1430182
 support-files = script_file_upload.js sw_file_upload.js server_file_upload.sjs
 [test_self_update_worker.html]
 skip-if = serviceworker_e10s
-  (toolkit == 'android' && !is_fennec)
+  toolkit == 'android'

dom/serviceworkers/test/mochitest.ini

@@ -26,7 +26,7 @@ skip-if = condprof  #: timed out
 tags = mcb
 [test_openWindow.html]
 skip-if = 
-    toolkit == 'android' && !is_fennec # Bug 1620052
+    toolkit == 'android' # Bug 1620052
     xorigin # Bug 1792790
   condprof  #: timed out
 tags = openwindow

dom/smil/test/mochitest.ini

@@ -58,6 +58,6 @@ skip-if = true # bug 1358955.
 [test_smilUpdatedInterval.xhtml]
 [test_smilValues.xhtml]
 [test_smilWithTransition.html]
-skip-if = toolkit == 'android' && !is_fennec
+skip-if = toolkit == 'android'
 [test_smilWithXlink.xhtml]
 [test_smilXHR.xhtml]

dom/tests/mochitest/bugs/mochitest.ini

@@ -59,7 +59,7 @@ skip-if = toolkit == 'android'
 [test_bug342448.html]
 [test_bug345521.html]
 [test_bug346659.html]
-skip-if = toolkit == 'android' && !is_fennec && debug
+skip-if = toolkit == 'android' && debug
 [test_bug369306.html]
 skip-if = condprof  #: "The focus should not have been changed with URL=test2_bug369306.htm"
 [test_bug370098.html]
@@ -78,7 +78,7 @@ tags = openwindow
 [test_bug440572.html]
 [test_bug456151.html]
 [test_bug458091.html]
-skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
+skip-if = toolkit == 'android' # Bug 1525959
 [test_bug459848.html]
 [test_bug465263.html]
 [test_bug484775.html]

dom/u2f/tests/mochitest.ini

@@ -55,7 +55,7 @@ skip-if =
   win11_2009 # Bug 1718296 (Windows 10 1903+ has its own window and U2F that we cannot control with tests.)
 [test_override_request.html]
 skip-if =
-  toolkit == 'android' && !is_fennec  # Bug 1530681
+  toolkit == 'android'  # Bug 1530681
   xorigin  # Hangs
   win10_2004 # Bug 1718296 (Windows 10 1903+ has its own window and U2F that we cannot control with tests.)
   win11_2009 # Bug 1718296 (Windows 10 1903+ has its own window and U2F that we cannot control with tests.)

dom/xhr/tests/mochitest.ini

@@ -111,7 +111,7 @@ support-files = test_XHR_timeout.js
 [test_XHRResponseURL.html]
 [test_XHRSendData.html]
 [test_sync_xhr_document_write_with_iframe.html]
-skip-if = toolkit == "android" && debug && !is_fennec
+skip-if = toolkit == "android" && debug
 [test_sync_xhr_event_handling.html]
 support-files =
   file_sync_xhr_event_handling_helper.html

js/xpconnect/tests/mochitest/mochitest.ini

@@ -77,7 +77,7 @@ prefs =
 [test_bug691059.html]
 [test_bug720619.html]
 [test_bug731471.html]
-skip-if = toolkit == "android" && debug && !is_fennec
+skip-if = toolkit == "android" && debug
 [test_bug764389.html]
 [test_bug772288.html]
 [test_bug781476.html]

mobile/android/components/extensions/test/mochitest/mochitest.ini

@@ -28,7 +28,7 @@ prefs =
 [test_ext_tabs_goBack_goForward.html]
 [test_ext_tabs_insertCSS.html]
 [test_ext_tabs_lastAccessed.html]
-skip-if = !is_fennec # tab.lastAccessed not implemented
+skip-if = true # tab.lastAccessed not implemented
 [test_ext_tabs_reload.html]
 [test_ext_tabs_reload_bypass_cache.html]
 [test_ext_tabs_onUpdated.html]

testing/mochitest/runtestsremote.py

@@ -106,7 +106,6 @@ class MochiRemote(MochitestDesktop):
             % str(self.device.version)
         )
         mozinfo.info["android_version"] = str(self.device.version)
-        mozinfo.info["is_fennec"] = not ("geckoview" in options.app)
         mozinfo.info["is_emulator"] = self.device._device_serial.startswith("emulator-")
 
     def cleanup(self, options, final=False):

testing/mozharness/configs/android/android-x86_64-profile-generation.py

@@ -45,6 +45,5 @@ config = {
     },
     "bogomips_minimum": 3000,
     "android_version": 24,
-    "is_fennec": False,
     "is_emulator": True,
 }

testing/mozharness/configs/android/android-x86_64.py

@@ -42,6 +42,5 @@ config = {
     "bogomips_minimum": 3000,
     # in support of test-verify
     "android_version": 24,
-    "is_fennec": False,
     "is_emulator": True,
 }

testing/mozharness/mozharness/mozilla/testing/per_test_base.py

@@ -343,7 +343,6 @@ class SingleTestMixin(object):
             mozinfo.update(
                 {"android_version": str(self.config.get("android_version", 24))}
             )
-            mozinfo.update({"is_fennec": self.config.get("is_fennec", False)})
             mozinfo.update({"is_emulator": self.config.get("is_emulator", True)})
         mozinfo.update({"verify": True})
         self.info("Per-test run using mozinfo: %s" % str(mozinfo.info))

toolkit/components/passwordmgr/test/mochitest/mochitest.ini

@@ -38,7 +38,7 @@ support-files =
   pwmgr_common.js
   pwmgr_common_parent.js
   ../authenticate.sjs
-skip-if = toolkit == 'android' && !is_fennec # Don't run on GeckoView
+skip-if = toolkit == 'android' # Don't run on GeckoView
 
 # Note: new tests should use scheme = https unless they have a specific reason not to
 

uriloader/exthandler/tests/mochitest/mochitest.ini

@@ -1,15 +1,15 @@
 [test_invalidCharFileExtension.xhtml]
-skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
+skip-if = toolkit == 'android' # Bug 1525959
 support-files =
   HelperAppLauncherDialog_chromeScript.js
   invalidCharFileExtension.sjs
 [test_nullCharFile.xhtml]
-skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
+skip-if = toolkit == 'android' # Bug 1525959
 support-files =
   HelperAppLauncherDialog_chromeScript.js
 [test_unknown_ext_protocol_handlers.html]
 [test_unsafeBidiChars.xhtml]
-skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
+skip-if = toolkit == 'android' # Bug 1525959
 support-files =
   HelperAppLauncherDialog_chromeScript.js
   unsafeBidiFileName.sjs