Bug 1562412 - stop using build_signing loader. r=jlorenzo,Callek

Depends on D57189

Differential Revision: https://phabricator.services.mozilla.com/D57190

--HG--
extra : moz-landing-system : lando

taskcluster/ci/build-signing/kind.yml

@@ -2,7 +2,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 ---
-loader: taskgraph.loader.build_signing:loader
+loader: taskgraph.loader.single_dep:loader
 
 transforms:
     - taskgraph.transforms.name_sanity:transforms
@@ -13,3 +13,8 @@ transforms:
 kind-dependencies:
     - build
     - build-fat-aar
+
+only-for-attributes:
+    - nightly
+    - shippable
+    - enable-build-signing

taskcluster/ci/build/linux.yml

@@ -8,6 +8,7 @@ linux64/opt:
         product: firefox
         job-name: linux64-opt
     attributes:
+        enable-build-signing: true
         enable-full-crashsymbols: true
     treeherder:
         platform: linux64/opt
@@ -393,6 +394,7 @@ linux/opt:
         product: firefox
         job-name: linux-opt
     attributes:
+        enable-build-signing: true
         enable-full-crashsymbols: true
     treeherder:
         platform: linux32/opt

taskcluster/ci/build/macosx.yml

@@ -50,6 +50,7 @@ macosx64/opt:
         product: firefox
         job-name: macosx64-opt
     attributes:
+        enable-build-signing: true
         enable-full-crashsymbols: true
     treeherder:
         platform: osx-cross/opt

taskcluster/ci/build/windows.yml

@@ -17,6 +17,7 @@ win32/debug:
         product: firefox
         job-name: win32-debug
     attributes:
+        enable-build-signing: true
         enable-full-crashsymbols: true
     treeherder:
         platform: windows2012-32/debug
@@ -53,6 +54,7 @@ win32/opt:
         product: firefox
         job-name: win32-opt
     attributes:
+        enable-build-signing: true
         enable-full-crashsymbols: true
     treeherder:
         platform: windows2012-32/opt
@@ -90,6 +92,7 @@ win64/debug:
         product: firefox
         job-name: win64-debug
     attributes:
+        enable-build-signing: true
         enable-full-crashsymbols: true
     treeherder:
         platform: windows2012-64/debug
@@ -200,6 +203,7 @@ win64/opt:
         product: firefox
         job-name: win64-opt
     attributes:
+        enable-build-signing: true
         enable-full-crashsymbols: true
     treeherder:
         platform: windows2012-64/opt
@@ -657,6 +661,8 @@ win64-ccov/debug:
     index:
         product: firefox
         job-name: win64-ccov-debug
+    attributes:
+        enable-build-signing: true
     treeherder:
         platform: windows2012-64/ccov
         symbol: B
@@ -986,6 +992,7 @@ win64-aarch64/opt:
         product: firefox
         job-name: win64-aarch64-opt
     attributes:
+        enable-build-signing: true
         enable-full-crashsymbols: true
     treeherder:
         platform: windows2012-aarch64/opt

taskcluster/ci/release-eme-free-repack-signing/kind.yml

@@ -2,7 +2,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 ---
-loader: taskgraph.loader.build_signing:loader
+loader: taskgraph.loader.single_dep:loader
 
 transforms:
     - taskgraph.transforms.chunk_partners:transforms

taskcluster/ci/release-partner-repack-signing/kind.yml

@@ -2,7 +2,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 ---
-loader: taskgraph.loader.build_signing:loader
+loader: taskgraph.loader.single_dep:loader
 
 transforms:
     - taskgraph.transforms.chunk_partners:transforms

taskcluster/ci/release-source/kind.yml

@@ -25,6 +25,8 @@ job-defaults:
         env:
             TOOLTOOL_MANIFEST: "browser/config/tooltool-manifests/linux64/releng.manifest"
             PKG_SRCPACK_BASENAME: source
+    attributes:
+        shippable: true
     run:
         using: mozharness
         actions: [package-source]

taskcluster/docs/attributes.rst

@@ -332,6 +332,10 @@ disable-build-signing
 Some GeckoView-only tasks produce APKs, but not APKs that should be
 signed.  Set this to ``true`` to disable APK signing.
 
+enable-build-signing
+====================
+We enable build-signing for ``shippable``, ``nightly``, and ``enable-build-signing`` tasks.
+
 run-visual-metrics
 ==================
 If set to true, will run the visual metrics task on the provided

taskcluster/taskgraph/loader/build_signing.py

@@ -1,38 +0,0 @@
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-from __future__ import absolute_import, print_function, unicode_literals
-
-from taskgraph.loader.single_dep import loader as base_loader
-
-# XXX: This logic should rely in kind.yml. This hasn't been done in the original
-# patch because it required some heavy changes in single_dep.
-NON_NIGHTLY_LABELS_WHICH_SHOULD_SIGN_BUILDS = (
-    'build-win32/debug', 'build-win32/opt', 'build-win32/pgo',
-    'build-win64/debug', 'build-win64/opt', 'build-win64/pgo',
-    'build-win64-aarch64/opt', 'build-win64-aarch64/debug'
-    'build-win32-devedition/opt', 'build-win64-devedition/opt',
-    'build-win64-ccov/debug',
-    'build-linux/opt', 'build-linux64/opt', 'build-linux64/pgo',
-    'build-macosx64/opt',
-    'build-android-api-16/opt'
-    'release-source-linux64-source/opt',
-    'release-source-linux64-fennec-source/opt',
-    'release-source-linux64-devedition-source/opt',
-    'release-eme-free-repack-macosx64-shippable',
-    'release-partner-repack-macosx64-shippable',
-)
-
-
-def loader(kind, path, config, params, loaded_tasks):
-    jobs = base_loader(kind, path, config, params, loaded_tasks)
-
-    for job in jobs:
-        dependent_task = job['primary-dependency']
-        if dependent_task.attributes.get('nightly') or \
-                dependent_task.attributes.get('shippable') or \
-                dependent_task.label in NON_NIGHTLY_LABELS_WHICH_SHOULD_SIGN_BUILDS:
-            # Bug 1522581: Some GeckoView-only tasks produce APKs that shouldn't be signed.
-            if not dependent_task.attributes.get('disable-build-signing', False):
-                yield job