Bug 1263235, part 4 - Make PBrowserStream::Write's data argument last. r=jimm

This will reduce internal memory fragmentation for the IPC::Message used to make this call.

dom/plugins/ipc/BrowserStreamChild.cpp

@@ -81,8 +81,8 @@ BrowserStreamChild::~BrowserStreamChild()
 
 bool
 BrowserStreamChild::RecvWrite(const int32_t& offset,
-                              const Buffer& data,
-                              const uint32_t& newlength)
+                              const uint32_t& newlength,
+                              const Buffer& data)
 {
   PLUGIN_LOG_DEBUG_FUNCTION;
 

dom/plugins/ipc/BrowserStreamChild.h

@@ -34,8 +34,8 @@ public:
             uint16_t* stype);
 
   virtual bool RecvWrite(const int32_t& offset,
-                         const Buffer& data,
-                         const uint32_t& newsize) override;
+                         const uint32_t& newsize,
+                         const Buffer& data) override;
   virtual bool RecvNPP_StreamAsFile(const nsCString& fname) override;
   virtual bool RecvNPP_DestroyStream(const NPReason& reason) override;
   virtual bool Recv__delete__() override;

dom/plugins/ipc/BrowserStreamParent.cpp

@@ -193,8 +193,8 @@ BrowserStreamParent::Write(int32_t offset,
     len = kSendDataChunk;
 
   return SendWrite(offset,
-                   nsCString(static_cast<char*>(buffer), len),
-                   mStream->end) ?
+                   mStream->end,
+                   nsCString(static_cast<char*>(buffer), len)) ?
     len : -1;
 }
 

dom/plugins/ipc/PBrowserStream.ipdl

@@ -24,8 +24,8 @@ intr protocol PBrowserStream
   manager PPluginInstance;
 
 child:
-  async Write(int32_t offset, Buffer data,
-              uint32_t newlength);
+  async Write(int32_t offset, uint32_t newlength,
+              Buffer data);
   async NPP_StreamAsFile(nsCString fname);
 
   /**