Bug 1605041 - Fix static-analysis warning from bug 1586370. r=padenot

Depends on D57696

Differential Revision: https://phabricator.services.mozilla.com/D57783

--HG--
extra : moz-landing-system : lando

dom/media/GraphDriver.h

@@ -99,7 +99,7 @@ struct GraphInterface {
       explicit Stop(RefPtr<Runnable> aStoppedRunnable)
           : mStoppedRunnable(std::move(aStoppedRunnable)) {}
       Stop(const Stop&) = delete;
-      Stop(Stop&& aOther)
+      Stop(Stop&& aOther) noexcept
           : mStoppedRunnable(std::move(aOther.mStoppedRunnable)) {}
       ~Stop() { MOZ_ASSERT(!mStoppedRunnable); }
       RefPtr<Runnable> mStoppedRunnable;
@@ -114,7 +114,7 @@ struct GraphInterface {
           : mDriver(std::move(aDriver)),
             mSwitchedRunnable(std::move(aSwitchedRunnable)) {}
       SwitchDriver(const SwitchDriver&) = delete;
-      SwitchDriver(SwitchDriver&& aOther)
+      SwitchDriver(SwitchDriver&& aOther) noexcept
           : mDriver(std::move(aOther.mDriver)),
             mSwitchedRunnable(std::move(aOther.mSwitchedRunnable)) {}
       ~SwitchDriver() { MOZ_ASSERT(!mSwitchedRunnable); }
@@ -500,7 +500,7 @@ class OfflineClockDriver : public ThreadedDriver {
   OfflineClockDriver* AsOfflineClockDriver() override { return this; }
 
  protected:
-  TimeDuration WaitInterval() override { return 0; }
+  TimeDuration WaitInterval() override { return TimeDuration(); }
   MediaTime GetIntervalForIteration() override;
 
  private:

dom/media/GraphRunner.h

@@ -70,12 +70,7 @@ class GraphRunner final : public Runnable {
     IterationState(GraphTime aStateEnd, GraphTime aIterationEnd,
                    AudioMixer* aMixer)
         : mStateEnd(aStateEnd), mIterationEnd(aIterationEnd), mMixer(aMixer) {}
-    IterationState& operator=(const IterationState& aOther) {
-      mStateEnd = aOther.mStateEnd;
-      mIterationEnd = aOther.mIterationEnd;
-      mMixer = aOther.mMixer;
-      return *this;
-    }
+    IterationState& operator=(const IterationState& aOther) = default;
     GraphTime StateEnd() const { return mStateEnd; }
     GraphTime IterationEnd() const { return mIterationEnd; }
     AudioMixer* Mixer() const { return mMixer; }