Bug 1854913 - Turn off ESLint rule mozilla/use-chromeutils-generateqi for plain mochitests as it should not apply there. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D189099

.eslintrc.js

@@ -351,7 +351,6 @@ module.exports = {
         "mozilla/no-arbitrary-setTimeout": "off",
         "mozilla/no-define-cc-etc": "off",
         "mozilla/prefer-boolean-length-check": "off",
-        "mozilla/use-chromeutils-generateqi": "off",
         "mozilla/use-default-preference-values": "off",
         "mozilla/use-includes-instead-of-indexOf": "off",
         "mozilla/use-services": "off",
@@ -439,7 +438,6 @@ module.exports = {
         "mozilla/no-define-cc-etc": "off",
         "mozilla/reject-importGlobalProperties": "off",
         "mozilla/use-cc-etc": "off",
-        "mozilla/use-chromeutils-generateqi": "off",
         "mozilla/use-includes-instead-of-indexOf": "off",
         "mozilla/use-ownerGlobal": "off",
         "mozilla/use-services": "off",
@@ -580,7 +578,6 @@ module.exports = {
       rules: {
         "mozilla/no-useless-parameters": "off",
         "mozilla/no-useless-removeEventListener": "off",
-        "mozilla/use-chromeutils-generateqi": "off",
         "mozilla/use-services": "off",
         complexity: "off",
         "no-array-constructor": "off",

docshell/test/navigation/test_contentpolicy_block_window.html

@@ -35,7 +35,6 @@ var policyID = SpecialPowers.wrap(SpecialPowers.Components).ID("{b80e19d0-878f-d
 var policyName = "@mozilla.org/testpolicy;1";
 var policy = {
   // nsISupports implementation
-  // eslint-disable-next-line mozilla/use-chromeutils-generateqi
   QueryInterface(iid) {
     iid = SpecialPowers.wrap(iid);
     if (iid.equals(Ci.nsISupports) ||

dom/notification/test/chrome/test_notification_system_principal.xhtml

@@ -34,13 +34,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=874090
       this.showAlert();
     },
 
-    QueryInterface: function(aIID) {
-      if (aIID.equals(Ci.nsISupports) ||
-          aIID.equals(Ci.nsIAlertsService)) {
-        return this;
-      }
-      throw Components.Exception("", Cr.NS_ERROR_NO_INTERFACE);
-    },
+    QueryInterface: ChromeUtils.generateQI(["nsIAlertsService"]),
 
     createInstance: function(aIID) {
       return this.QueryInterface(aIID);

dom/notification/test/mochitest/MockServices.js

@@ -1,4 +1,3 @@
-/* eslint-disable mozilla/use-chromeutils-generateqi */
 var MockServices = (function () {
   "use strict";
 

image/test/mochitest/test_net_failedtoprocess.html

@@ -23,7 +23,6 @@ var obs = Cc["@mozilla.org/observer-service;1"].getService();
 obs = obs.QueryInterface(Ci.nsIObserverService);
 
 var observer = {
-  /* eslint-disable-next-line mozilla/use-chromeutils-generateqi */
   QueryInterface (aIID) {
     if (aIID.equals(Ci.nsISupports) ||
         aIID.equals(Ci.nsIObserver))

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/mochitest-test.js

@@ -54,6 +54,9 @@ module.exports = {
     // We mis-predict globals for HTML test files in directories shared
     // with browser tests, so don't try to "fix" imports that are needed.
     "mozilla/no-redeclare-with-import-autofix": "off",
+    // Turn off use-chromeutils-generateqi as these tests don't have ChromeUtils
+    // available.
+    "mozilla/use-chromeutils-generateqi": "off",
     "no-shadow": "error",
   },
 };

tools/lint/eslint/eslint-plugin-mozilla/lib/rules/use-chromeutils-generateqi.js

@@ -48,7 +48,7 @@ module.exports = {
     fixable: "code",
     messages: {
       noJSQueryInterface:
-        "Please use ChromeUtils.generateQI rather than" +
+        "Please use ChromeUtils.generateQI rather than " +
         "manually creating JavaScript QueryInterface functions",
       noXpcomUtilsGenerateQI:
         "Please use ChromeUtils.generateQI instead of XPCOMUtils.generateQI",