From ae0dd13fe25c29e64a32434c44068447ee835f56 Mon Sep 17 00:00:00 2001 From: Bill McCloskey Date: Fri, 1 Sep 2017 16:29:25 -0700 Subject: [PATCH] Bug 1397468 - Shmem creation/destruction messages should not be SystemGroup (r=dvander) It's important that shmem creation/destruction messages be ordered correctly with respect to other messages that use shmems. For example, if we create a shmem with ID 10 and then send a message that references shmem 10, then the creation message must be handled before the referencing message. If shmem creation/destruction messages go in a separate queue from other messages, this ordering may not be preserved. Leaving shmem creation/destruction unlabeled will give us the correct ordering. Eventually, though, we'll need to provide a solution that doesn't bottleneck the event queue. MozReview-Commit-ID: 88MrslRrfnh --- ipc/glue/ProtocolUtils.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/ipc/glue/ProtocolUtils.cpp b/ipc/glue/ProtocolUtils.cpp index a38c96e2fc30..051ec1f49f9b 100644 --- a/ipc/glue/ProtocolUtils.cpp +++ b/ipc/glue/ProtocolUtils.cpp @@ -826,13 +826,6 @@ IToplevelProtocol::ShmemDestroyed(const Message& aMsg) already_AddRefed IToplevelProtocol::GetMessageEventTarget(const Message& aMsg) { - if (IsMainThreadProtocol() && SystemGroup::Initialized()) { - if (aMsg.type() == SHMEM_CREATED_MESSAGE_TYPE || - aMsg.type() == SHMEM_DESTROYED_MESSAGE_TYPE) { - return do_AddRef(SystemGroup::EventTargetFor(TaskCategory::Other)); - } - } - int32_t route = aMsg.routing_id(); Maybe lock;