зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1386588 - Avoid wildcards in toolchain resources lists. r=gps
Those resources are used to compute a unique identifier for the toolchain, and changes to those files will change the unique identifier, and lead to the toolchain being rebuilt. Using wildcards, especially in the build-clang directory, makes all the files from there used for the unique identifier, even files irrelevant. The side effect is that any change to any json file for clang toolchains currently triggers *all* clang toolchains to be rebuilt, which is a waste of resources and time. But while it is tempting to list all the files involved, it is also tedious and error-prone. Specifically, listing the relevant patch files for clang toolchain builds is bound to end up outdated. OTOH, we're not trying to mitigate bad actors here, but just to avoid shooting ourselves in the foot. And patch files are, in practice, not changed. The jsons are changed to reference them or not, but the patches themselves don't change in relevant ways. They may be updated for new versions of clang, which require a json change anyways. So we ignore the patch files.
This commit is contained in:
Родитель
1bee705e53
Коммит
af9b7241e1
|
@ -17,7 +17,8 @@ linux64-clang:
|
|||
using: toolchain-script
|
||||
script: build-clang-linux.sh
|
||||
resources:
|
||||
- 'build/build-clang/**'
|
||||
- 'build/build-clang/build-clang.py'
|
||||
- 'build/build-clang/clang-linux64.json'
|
||||
- 'taskcluster/scripts/misc/tooltool-download.sh'
|
||||
toolchain-artifact: public/build/clang.tar.xz
|
||||
toolchains:
|
||||
|
@ -42,7 +43,8 @@ linux64-clang-tidy:
|
|||
script: build-clang-tidy-linux.sh
|
||||
resources:
|
||||
- 'build/clang-plugin/**'
|
||||
- 'build/build-clang/**'
|
||||
- 'build/build-clang/build-clang.py'
|
||||
- 'build/build-clang/clang-tidy-linux64.json'
|
||||
- 'taskcluster/scripts/misc/tooltool-download.sh'
|
||||
toolchain-artifact: public/build/clang-tidy.tar.xz
|
||||
toolchains:
|
||||
|
@ -63,7 +65,8 @@ linux64-gcc:
|
|||
using: toolchain-script
|
||||
script: build-gcc-linux.sh
|
||||
resources:
|
||||
- 'build/unix/build-gcc/**'
|
||||
- 'build/unix/build-gcc/build-gcc.sh'
|
||||
- 'build/unix/build-gcc/checksums'
|
||||
toolchain-artifact: public/build/gcc.tar.xz
|
||||
|
||||
linux64-binutils:
|
||||
|
@ -81,7 +84,7 @@ linux64-binutils:
|
|||
using: toolchain-script
|
||||
script: build-binutils-linux.sh
|
||||
resources:
|
||||
- 'build/unix/build-binutils/**'
|
||||
- 'build/unix/build-binutils/build-binutils.sh'
|
||||
toolchain-artifact: public/build/binutils.tar.xz
|
||||
|
||||
linux64-cctools-port:
|
||||
|
@ -119,7 +122,7 @@ linux64-hfsplus:
|
|||
using: toolchain-script
|
||||
script: build-hfsplus-linux.sh
|
||||
resources:
|
||||
- 'build/unix/build-hfsplus/**'
|
||||
- 'build/unix/build-hfsplus/build-hfsplus.sh'
|
||||
- 'taskcluster/scripts/misc/tooltool-download.sh'
|
||||
toolchain-artifact: public/build/hfsplus-tools.tar.xz
|
||||
toolchains:
|
||||
|
|
|
@ -20,7 +20,8 @@ macosx64-clang:
|
|||
script: build-clang-macosx.sh
|
||||
tooltool-downloads: internal
|
||||
resources:
|
||||
- 'build/build-clang/**'
|
||||
- 'build/build-clang/build-clang.py'
|
||||
- 'build/build-clang/clang-macosx64.json'
|
||||
- 'taskcluster/scripts/misc/tooltool-download.sh'
|
||||
toolchain-artifact: public/build/clang.tar.xz
|
||||
toolchains:
|
||||
|
@ -50,7 +51,8 @@ macosx64-clang-tidy:
|
|||
tooltool-downloads: internal
|
||||
resources:
|
||||
- 'build/clang-plugin/**'
|
||||
- 'build/build-clang/**'
|
||||
- 'build/build-clang/build-clang.py'
|
||||
- 'build/build-clang/clang-tidy-macosx64.json'
|
||||
- 'taskcluster/scripts/misc/tooltool-download.sh'
|
||||
toolchain-artifact: public/build/clang-tidy.tar.xz
|
||||
toolchains:
|
||||
|
|
|
@ -18,7 +18,8 @@ win32-clang-cl:
|
|||
using: toolchain-script
|
||||
script: build-clang32-windows.sh
|
||||
resources:
|
||||
- 'build/build-clang/**'
|
||||
- 'build/build-clang/build-clang.py'
|
||||
- 'build/build-clang/clang-win32.json'
|
||||
- 'taskcluster/scripts/misc/build-clang-windows-helper32.sh'
|
||||
toolchain-artifact: public/build/clang.tar.bz2
|
||||
|
||||
|
@ -38,7 +39,8 @@ win64-clang-cl:
|
|||
using: toolchain-script
|
||||
script: build-clang64-windows.sh
|
||||
resources:
|
||||
- 'build/build-clang/**'
|
||||
- 'build/build-clang/build-clang.py'
|
||||
- 'build/build-clang/clang-win64.json'
|
||||
- 'taskcluster/scripts/misc/build-clang-windows-helper64.sh'
|
||||
toolchain-artifact: public/build/clang.tar.bz2
|
||||
|
||||
|
@ -61,7 +63,9 @@ win32-clang-tidy:
|
|||
using: toolchain-script
|
||||
script: build-clang-tidy32-windows.sh
|
||||
resources:
|
||||
- 'build/build-clang/**'
|
||||
- 'build/clang-plugin/**'
|
||||
- 'build/build-clang/build-clang.py'
|
||||
- 'build/build-clang/clang-tidy-win32.json'
|
||||
- 'taskcluster/scripts/misc/build-clang-windows-helper32.sh'
|
||||
toolchain-artifact: public/build/clang-tidy.tar.bz2
|
||||
|
||||
|
@ -84,7 +88,9 @@ win64-clang-tidy:
|
|||
using: toolchain-script
|
||||
script: build-clang-tidy64-windows.sh
|
||||
resources:
|
||||
- 'build/build-clang/**'
|
||||
- 'build/clang-plugin/**'
|
||||
- 'build/build-clang/build-clang.py'
|
||||
- 'build/build-clang/clang-tidy-win32.json'
|
||||
- 'taskcluster/scripts/misc/build-clang-windows-helper64.sh'
|
||||
toolchain-artifact: public/build/clang-tidy.tar.bz2
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче