Bug 171274: check shell type for primary content frames. r=/sr=jst,hyatt, a=drivers

content/base/src/nsFrameLoader.cpp

@@ -450,17 +450,8 @@ nsFrameLoader::EnsureDocShell()
       }
     }
 
-    if (isContent) {
+    PRInt32 shellType = isContent ? nsIDocShellTreeItem::typeContent : parentType;
-      // The web shell's type is content.
+    docShellAsItem->SetItemType(shellType);
-
-      docShellAsItem->SetItemType(nsIDocShellTreeItem::typeContent);
-    } else {
-      // Inherit our type from our parent webshell.  If it is
-      // chrome, we'll be chrome.  If it is content, we'll be
-      // content.
-
-      docShellAsItem->SetItemType(parentType);
-    }
 
     parentAsNode->AddChild(docShellAsItem);
 
@@ -469,7 +460,8 @@ nsFrameLoader::EnsureDocShell()
       parentAsItem->GetTreeOwner(getter_AddRefs(parentTreeOwner));
 
       if(parentTreeOwner) {
-        PRBool is_primary = value.Equals(NS_LITERAL_STRING("content-primary"));
+        PRBool is_primary = shellType == nsIDocShellTreeItem::typeChrome &&
+                            value.Equals(NS_LITERAL_STRING("content-primary"));
 
         parentTreeOwner->ContentShellAdded(docShellAsItem, is_primary,
                                            value.get());

layout/generic/nsFrameFrame.cpp

@@ -683,7 +683,10 @@ nsHTMLFrameOuterFrame::AttributeChanged(nsIPresContext* aPresContext,
       nsCOMPtr<nsIDocShellTreeOwner> parentTreeOwner;
       parentAsItem->GetTreeOwner(getter_AddRefs(parentTreeOwner));
       if (parentTreeOwner) {
+        PRInt32 shellType;
+        parentAsItem->GetItemType(&shellType);
         PRBool is_primary_content =
+          shellType == nsIDocShellTreeItem::typeChrome &&
           value.EqualsIgnoreCase("content-primary");
 
         parentTreeOwner->ContentShellAdded(docShellAsItem, is_primary_content,

layout/html/document/src/nsFrameFrame.cpp

@@ -683,7 +683,10 @@ nsHTMLFrameOuterFrame::AttributeChanged(nsIPresContext* aPresContext,
       nsCOMPtr<nsIDocShellTreeOwner> parentTreeOwner;
       parentAsItem->GetTreeOwner(getter_AddRefs(parentTreeOwner));
       if (parentTreeOwner) {
+        PRInt32 shellType;
+        parentAsItem->GetItemType(&shellType);
         PRBool is_primary_content =
+          shellType == nsIDocShellTreeItem::typeChrome &&
           value.EqualsIgnoreCase("content-primary");
 
         parentTreeOwner->ContentShellAdded(docShellAsItem, is_primary_content,