Bug 1476475 - Use -W4 for certverifier with clang-cl. r=froydnj

MozReview-Commit-ID: 9OVJ2CFO0Qb

--HG--
extra : rebase_source : 3f0b89c6e8f54e34afa19c74a0574a258912c940

security/certverifier/moz.build

@@ -61,7 +61,14 @@ TEST_DIRS += [
     'tests/gtest',
 ]
 
-CXXFLAGS += ['-Wall']
+if CONFIG['CC_TYPE'] == 'clang-cl':
+    # -Wall on clang-cl maps to -Weverything, which turns on way too
+    # much, so we're using -W4 instead, which is mapped to clang's
+    # -Wall -Wextra.
+    CXXFLAGS += ['-W4']
+else:
+    CXXFLAGS += ['-Wall']
+
 if CONFIG['CC_TYPE'] in ('msvc', 'clang-cl'):
     # -Wall with Visual C++ enables too many problematic warnings
     CXXFLAGS += [