Bug 1116769 - Change webapprt downloadItems to a Map and remove nonstandard for-each-in loops. r=mak

webapprt/content/downloads/downloads.js

@@ -578,7 +578,7 @@ DownloadItem.prototype = {
 
 let gDownloadList = {
   downloadItemsMap: new Map(),
-  downloadItems: {},
+  idToDownloadItemMap: new Map(),
   _autoIncrementID: 0,
   downloadView: null,
   searchBox: null,
@@ -727,7 +727,7 @@ let gDownloadList = {
     this.downloadView.parentNode.replaceChild(empty, this.downloadView);
     this.downloadView = empty;
 
-    for each (let downloadItem in this.downloadItems) {
+    for (let downloadItem of this.idToDownloadItemMap.values()) {
       if (downloadItem.inProgress ||
           downloadItem.matchesSearch(this.searchTerms, this.searchAttributes)) {
         this.downloadView.appendChild(downloadItem.element);
@@ -773,7 +773,7 @@ let gDownloadList = {
     let button = document.getElementById("clearListButton");
 
     // The button is enabled if we have items in the list that we can clean up.
-    for each (let downloadItem in this.downloadItems) {
+    for (let downloadItem of this.idToDownloadItemMap.values()) {
       if (!downloadItem.inProgress &&
           downloadItem.matchesSearch(this.searchTerms, this.searchAttributes)) {
         button.disabled = false;
@@ -808,8 +808,7 @@ let gDownloadList = {
     }
 
     if (this.downloadView.selectedItem) {
-      let dl = this.downloadView.selectedItem;
-      let downloadItem = this.downloadItems[dl.getAttribute("id")];
+      let downloadItem = this._getSelectedDownloadItem();
 
       let idx = downloadItem.state;
       if (idx < 0) {
@@ -838,13 +837,11 @@ let gDownloadList = {
    */
   doDefaultForSelected: function() {
     // Make sure we have something selected.
-    let item = this.downloadView.selectedItem;
-    if (!item) {
+    let download = this._getSelectedDownloadItem();
+    if (!download) {
       return;
     }
 
-    let download = this.downloadItems[item.getAttribute("id")];
-
     // Get the default action (first item in the menu).
     let menuitem = document.getElementById(this.contextMenus[download.state][0]);
 
@@ -891,17 +888,17 @@ let gDownloadList = {
       elm = elm.parentNode;
     }
 
-    let downloadItem = this.downloadItems[elm.getAttribute("id")];
+    let downloadItem = this._getDownloadItemForElement(elm);
     downloadItem.doCommand(aCmd);
   },
 
   onDragStart: function(aEvent) {
-    if (!this.downloadView.selectedItem) {
+    let downloadItem = this._getSelectedDownloadItem();
+    if (!downloadItem) {
       return;
     }
 
     let dl = this.downloadView.selectedItem;
-    let downloadItem = this.downloadItems[dl.getAttribute("id")];
     let f = downloadItem.localFile;
     if (!f.exists()) {
       return;
@@ -983,7 +980,7 @@ let gDownloadList = {
     let totalSize = 0;
     let totalTransferred = 0;
 
-    for each (let downloadItem in this.downloadItems) {
+    for (let downloadItem of this.idToDownloadItemMap.values()) {
       if (!downloadItem.inProgress) {
         continue;
       }
@@ -1030,7 +1027,7 @@ let gDownloadList = {
 
     let downloadItem = new DownloadItem(newID, aDownload);
     this.downloadItemsMap.set(aDownload, downloadItem);
-    this.downloadItems[newID] = downloadItem;
+    this.idToDownloadItemMap.set(newID, downloadItem);
 
     if (downloadItem.inProgress ||
         downloadItem.matchesSearch(this.searchTerms, this.searchAttributes)) {
@@ -1088,7 +1085,7 @@ let gDownloadList = {
     }
 
     this.downloadItemsMap.delete(aDownload);
-    delete this.downloadItems[downloadItem.id];
+    this.idToDownloadItemMap.delete(downloadItem.id);
 
     this.removeFromView(downloadItem);
   },
@@ -1106,6 +1103,13 @@ let gDownloadList = {
     // We might have removed the last item, so update the clear list button.
     this.updateClearListButton();
   },
+  _getDownloadItemForElement(element) {
+    return this.idToDownloadItemMap.get(element.getAttribute("id"));
+  },
+  _getSelectedDownloadItem() {
+    let dl = this.downloadView.selectedItem;
+    return dl ? this._getDownloadItemForElement(dl) : null;
+  },
 };
 
 function Startup() {