From b0c8cf0cf73681f0d34a341d9aa65a787abe26a7 Mon Sep 17 00:00:00 2001 From: Maja Frydrychowicz Date: Mon, 27 Apr 2020 15:04:51 +0000 Subject: [PATCH] Bug 1633042 - [remote] Compare frame id after load event r=remote-protocol-reviewers,whimboo Differential Revision: https://phabricator.services.mozilla.com/D72559 --- remote/test/browser/page/browser_navigate.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/remote/test/browser/page/browser_navigate.js b/remote/test/browser/page/browser_navigate.js index ccc6c0ed29f0..b1e1c6ca159b 100644 --- a/remote/test/browser/page/browser_navigate.js +++ b/remote/test/browser/page/browser_navigate.js @@ -14,11 +14,11 @@ add_task(async function testBasicNavigation({ client }) { url: pageEmptyURL, }); - await compareFrame(frameId); todo(!!loaderId, "Page.navigate returns loaderId"); is(errorText, undefined, "No errorText on a successful navigation"); await loadEventFired; + await compareFrame(frameId); is( gBrowser.selectedBrowser.currentURI.spec, pageEmptyURL, @@ -160,11 +160,11 @@ add_task(async function testDataURL({ client }) { await Page.enable(); const loadEventFired = Page.loadEventFired(); const { frameId, loaderId, errorText } = await Page.navigate({ url }); - await compareFrame(frameId); is(errorText, undefined, "No errorText on a successful navigation"); todo(!!loaderId, "Page.navigate returns loaderId"); await loadEventFired; + await compareFrame(frameId); is(gBrowser.selectedBrowser.currentURI.spec, url, "Expected URL loaded"); }); @@ -177,9 +177,9 @@ add_task(async function testAbout({ client }) { }); todo(!!loaderId, "Page.navigate returns loaderId"); is(errorText, undefined, "No errorText on a successful navigation"); - await compareFrame(frameId); await loadEventFired; + await compareFrame(frameId); is( gBrowser.selectedBrowser.currentURI.spec, "about:blank",