зеркало из https://github.com/mozilla/gecko-dev.git
Backed out 3 changesets (bug 1459404) for xpcshell failures in toolkit/components/extensions/test/xpcshell/test_ext_contexts_gc.js on a CLOSED TREE
Backed out changeset 0cf499a0fee9 (bug 1459404) Backed out changeset 333c6bee4e9c (bug 1459404) Backed out changeset 0f5d5144aeee (bug 1459404)
This commit is contained in:
Margareta Eliza Balazs
Родитель
9de29c1f5a
Коммит
b0eaf1fc9f
|
|
@ -87,7 +87,7 @@ Damp.prototype = {
|
|||
// as it slow down next executions almost like a cold start.
|
||||
|
||||
// See minimizeMemoryUsage code to justify the 3 iterations and the setTimeout:
|
||||
// https://searchfox.org/mozilla-central/rev/33c21c060b7f3a52477a73d06ebcb2bf313c4431/xpcom/base/nsMemoryReporterManager.cpp#2574-2585,2591-2594
|
||||
// https://searchfox.org/mozilla-central/source/xpcom/base/nsMemoryReporterManager.cpp#2574-2585
|
||||
for (let i = 0; i < 3; i++) {
|
||||
// See minimizeMemoryUsage code here to justify the GC+CC+GC:
|
||||
// https://searchfox.org/mozilla-central/rev/be78e6ea9b10b1f5b2b3b013f01d86e1062abb2b/dom/base/nsJSEnvironment.cpp#341-349
|
||||
|
|
|
|||
|
|
@ -1034,9 +1034,6 @@ class ChildAPIManager {
|
|||
|
||||
close() {
|
||||
this.messageManager.sendAsyncMessage("API:CloseProxyContext", {childId: this.id});
|
||||
this.messageManager.removeMessageListener("API:CallResult", this);
|
||||
MessageChannel.removeListener(this.messageManager, "API:RunListener", this);
|
||||
|
||||
if (this.updatePermissions) {
|
||||
this.context.extension.off("add-permissions", this.updatePermissions);
|
||||
this.context.extension.off("remove-permissions", this.updatePermissions);
|
||||
|
|
|
|||
|
|
@ -1,234 +0,0 @@
|
|||
"use strict";
|
||||
|
||||
const server = createHttpServer();
|
||||
server.registerDirectory("/data/", do_get_file("data"));
|
||||
|
||||
const BASE_URL = `http://localhost:${server.identity.primaryPort}/data`;
|
||||
|
||||
// ExtensionContent.jsm needs to know when it's running from xpcshell,
|
||||
// to use the right timeout for content scripts executed at document_idle.
|
||||
ExtensionTestUtils.mockAppInfo();
|
||||
|
||||
// Each of these tests do the following:
|
||||
// 1. Load document to create an extension context (instance of BaseContext).
|
||||
// 2. Get weak reference to that context.
|
||||
// 3. Unload the document.
|
||||
// 4. Force GC and check that the weak reference has been invalidated.
|
||||
|
||||
async function reloadTopContext(contentPage) {
|
||||
await contentPage.spawn(null, async () => {
|
||||
let {TestUtils} = ChromeUtils.import("resource://testing-common/TestUtils.jsm", {});
|
||||
let windowNukeObserved = TestUtils.topicObserved("inner-window-nuked");
|
||||
info(`Reloading top-level document`);
|
||||
this.content.location.reload();
|
||||
await windowNukeObserved;
|
||||
info(`Reloaded top-level document`);
|
||||
});
|
||||
}
|
||||
|
||||
async function assertContextReleased(contentPage, description) {
|
||||
await contentPage.spawn(description, async assertionDescription => {
|
||||
// Force GC, see https://searchfox.org/mozilla-central/rev/b0275bc977ad7fda615ef34b822bba938f2b16fd/testing/talos/talos/tests/devtools/addon/content/damp.js#84-98
|
||||
// and https://searchfox.org/mozilla-central/rev/33c21c060b7f3a52477a73d06ebcb2bf313c4431/xpcom/base/nsMemoryReporterManager.cpp#2574-2585,2591-2594
|
||||
let gcCount = 0;
|
||||
while (gcCount < 30 && this.contextWeakRef.get() !== null) {
|
||||
++gcCount;
|
||||
Cu.forceGC();
|
||||
Cu.forceCC();
|
||||
Cu.forceGC();
|
||||
await new Promise(resolve => this.content.setTimeout(resolve, 0));
|
||||
}
|
||||
|
||||
// The above loop needs to be repeated at most 3 times according to MinimizeMemoryUsage:
|
||||
// https://searchfox.org/mozilla-central/rev/6f86cc3479f80ace97f62634e2c82a483d1ede40/xpcom/base/nsMemoryReporterManager.cpp#2644-2647
|
||||
Assert.lessOrEqual(gcCount, 3, `Context should have been GCd within a few GC attempts.`);
|
||||
|
||||
// Each test will set this.contextWeakRef before unloading the document.
|
||||
Assert.ok(!this.contextWeakRef.get(), assertionDescription);
|
||||
});
|
||||
}
|
||||
|
||||
add_task(async function test_ContentScriptContextChild_in_child_frame() {
|
||||
let extensionData = {
|
||||
manifest: {
|
||||
content_scripts: [
|
||||
{
|
||||
matches: ["http://*/*/file_iframe.html"],
|
||||
js: ["content_script.js"],
|
||||
all_frames: true,
|
||||
},
|
||||
],
|
||||
},
|
||||
|
||||
files: {
|
||||
"content_script.js": "browser.test.sendMessage('contentScriptLoaded');",
|
||||
},
|
||||
};
|
||||
|
||||
let extension = ExtensionTestUtils.loadExtension(extensionData);
|
||||
await extension.startup();
|
||||
|
||||
let contentPage = await ExtensionTestUtils.loadContentPage(`${BASE_URL}/file_toplevel.html`);
|
||||
await extension.awaitMessage("contentScriptLoaded");
|
||||
|
||||
await contentPage.spawn(extension.id, async extensionId => {
|
||||
let {DocumentManager} = ChromeUtils.import("resource://gre/modules/ExtensionContent.jsm", {});
|
||||
let frame = this.content.document.querySelector("iframe[src*='file_iframe.html']");
|
||||
let context = DocumentManager.getContext(extensionId, frame.contentWindow);
|
||||
|
||||
Assert.ok(context, "Got content script context");
|
||||
|
||||
this.contextWeakRef = Cu.getWeakReference(context);
|
||||
frame.remove();
|
||||
});
|
||||
|
||||
await assertContextReleased(contentPage, "ContentScriptContextChild should have been released");
|
||||
|
||||
await contentPage.close();
|
||||
await extension.unload();
|
||||
});
|
||||
|
||||
add_task(async function test_ContentScriptContextChild_in_toplevel() {
|
||||
let extensionData = {
|
||||
manifest: {
|
||||
content_scripts: [
|
||||
{
|
||||
matches: ["http://*/*/file_sample.html"],
|
||||
js: ["content_script.js"],
|
||||
all_frames: true,
|
||||
},
|
||||
],
|
||||
},
|
||||
|
||||
files: {
|
||||
"content_script.js": "browser.test.sendMessage('contentScriptLoaded');",
|
||||
},
|
||||
};
|
||||
|
||||
let extension = ExtensionTestUtils.loadExtension(extensionData);
|
||||
await extension.startup();
|
||||
|
||||
let contentPage = await ExtensionTestUtils.loadContentPage(`${BASE_URL}/file_sample.html`);
|
||||
await extension.awaitMessage("contentScriptLoaded");
|
||||
|
||||
await contentPage.spawn(extension.id, async extensionId => {
|
||||
let {DocumentManager} = ChromeUtils.import("resource://gre/modules/ExtensionContent.jsm", {});
|
||||
let context = DocumentManager.getContext(extensionId, this.content);
|
||||
|
||||
Assert.ok(context, "Got content script context");
|
||||
|
||||
this.contextWeakRef = Cu.getWeakReference(context);
|
||||
});
|
||||
|
||||
await reloadTopContext(contentPage);
|
||||
await extension.awaitMessage("contentScriptLoaded");
|
||||
await assertContextReleased(contentPage, "ContentScriptContextChild should have been released");
|
||||
|
||||
await contentPage.close();
|
||||
await extension.unload();
|
||||
});
|
||||
|
||||
add_task(async function test_ExtensionPageContextChild_in_child_frame() {
|
||||
let extensionData = {
|
||||
files: {
|
||||
"iframe.html": `
|
||||
<!DOCTYPE html><meta charset="utf8">
|
||||
<script src="script.js"></script>
|
||||
`,
|
||||
"toplevel.html": `
|
||||
<!DOCTYPE html><meta charset="utf8">
|
||||
<iframe src="iframe.html"></iframe>
|
||||
`,
|
||||
"script.js": "browser.test.sendMessage('extensionPageLoaded');",
|
||||
},
|
||||
};
|
||||
|
||||
let extension = ExtensionTestUtils.loadExtension(extensionData);
|
||||
await extension.startup();
|
||||
|
||||
let contentPage = await ExtensionTestUtils.loadContentPage(`moz-extension://${extension.uuid}/toplevel.html`, {
|
||||
extension,
|
||||
remote: extension.extension.remote,
|
||||
});
|
||||
await extension.awaitMessage("extensionPageLoaded");
|
||||
|
||||
await contentPage.spawn(extension.id, async extensionId => {
|
||||
let {ExtensionPageChild} = ChromeUtils.import("resource://gre/modules/ExtensionPageChild.jsm", {});
|
||||
|
||||
let frame = this.content.document.querySelector("iframe[src*='iframe.html']");
|
||||
let innerWindowID =
|
||||
frame.contentWindow
|
||||
.QueryInterface(Ci.nsIInterfaceRequestor)
|
||||
.getInterface(Ci.nsIDOMWindowUtils)
|
||||
.currentInnerWindowID;
|
||||
let context = ExtensionPageChild.extensionContexts.get(innerWindowID);
|
||||
|
||||
Assert.ok(context, "Got extension page context for child frame");
|
||||
|
||||
this.contextWeakRef = Cu.getWeakReference(context);
|
||||
frame.remove();
|
||||
});
|
||||
|
||||
await assertContextReleased(contentPage, "ExtensionPageContextChild should have been released");
|
||||
|
||||
await contentPage.close();
|
||||
await extension.unload();
|
||||
});
|
||||
|
||||
add_task(async function test_ExtensionPageContextChild_in_toplevel() {
|
||||
let extensionData = {
|
||||
files: {
|
||||
"toplevel.html": `
|
||||
<!DOCTYPE html><meta charset="utf8">
|
||||
<iframe src="iframe.html"></iframe>
|
||||
<script src="script.js"></script>
|
||||
`,
|
||||
"script.js": "browser.test.sendMessage('extensionPageLoaded');",
|
||||
},
|
||||
};
|
||||
|
||||
let extension = ExtensionTestUtils.loadExtension(extensionData);
|
||||
await extension.startup();
|
||||
|
||||
let contentPage = await ExtensionTestUtils.loadContentPage(`moz-extension://${extension.uuid}/toplevel.html`, {
|
||||
extension,
|
||||
remote: extension.extension.remote,
|
||||
});
|
||||
await extension.awaitMessage("extensionPageLoaded");
|
||||
|
||||
await contentPage.spawn(extension.id, async extensionId => {
|
||||
let {ExtensionPageChild} = ChromeUtils.import("resource://gre/modules/ExtensionPageChild.jsm", {});
|
||||
|
||||
let innerWindowID = this.content
|
||||
.QueryInterface(Ci.nsIInterfaceRequestor)
|
||||
.getInterface(Ci.nsIDOMWindowUtils)
|
||||
.currentInnerWindowID;
|
||||
let context = ExtensionPageChild.extensionContexts.get(innerWindowID);
|
||||
|
||||
Assert.ok(context, "Got extension page context for top-level document");
|
||||
|
||||
this.contextWeakRef = Cu.getWeakReference(context);
|
||||
});
|
||||
|
||||
await reloadTopContext(contentPage);
|
||||
await extension.awaitMessage("extensionPageLoaded");
|
||||
// For some unknown reason, the context cannot forcidbly be released by the
|
||||
// garbage collector unless we wait for a short while.
|
||||
await contentPage.spawn(null, async () => {
|
||||
let start = Date.now();
|
||||
// The treshold was found after running this subtest only, 300 times
|
||||
// in a release build (100 of xpcshell, xpcshell-e10s and xpcshell-remote).
|
||||
// With treshold 8, almost half of the tests complete after a 17-18 ms delay.
|
||||
// With treshold 7, over half of the tests complete after a 13-14 ms delay,
|
||||
// with 12 failures in 300 tests runs.
|
||||
// Let's double that number to have a safety margin.
|
||||
for (let i = 0; i < 15; ++i) {
|
||||
await new Promise(resolve => this.content.setTimeout(resolve, 0));
|
||||
}
|
||||
info(`Going to GC after waiting for ${Date.now() - start} ms.`);
|
||||
});
|
||||
await assertContextReleased(contentPage, "ExtensionPageContextChild should have been released");
|
||||
|
||||
await contentPage.close();
|
||||
await extension.unload();
|
||||
});
|
||||
|
|
@ -8,7 +8,6 @@ skip-if = debug # Bug 1407501
|
|||
skip-if = (os == "android" && debug) || (os == "win" && debug) # Windows: Bug 1438796
|
||||
[test_ext_contentscript_xrays.js]
|
||||
[test_ext_contentScripts_register.js]
|
||||
[test_ext_contexts_gc.js]
|
||||
skip-if = os == "android"
|
||||
[test_ext_adoption_with_xrays.js]
|
||||
[test_ext_shadowdom.js]
|
||||
|
|
|
|||
Загрузка…
Ссылка в новой задаче