Bug 1526591 - Remove devtools.inspector.shapesHighlighter.enabled pref. r=rcaliman

Differential Revision: https://phabricator.services.mozilla.com/D19255

devtools/client/inspector/rules/test/head.js

@@ -21,14 +21,11 @@ var {getInplaceEditorForSpan: inplaceEditor} =
 const ROOT_TEST_DIR = getRootDirectory(gTestPath);
 const FRAME_SCRIPT_URL = ROOT_TEST_DIR + "doc_frame_script.js";
 
-const STYLE_INSPECTOR_L10N
-      = new LocalizationHelper("devtools/shared/locales/styleinspector.properties");
-
-Services.prefs.setBoolPref("devtools.inspector.shapesHighlighter.enabled", true);
+const STYLE_INSPECTOR_L10N =
+  new LocalizationHelper("devtools/shared/locales/styleinspector.properties");
 
 registerCleanupFunction(() => {
   Services.prefs.clearUserPref("devtools.defaultColorUnit");
-  Services.prefs.clearUserPref("devtools.inspector.shapesHighlighter.enabled");
 });
 
 /**

devtools/client/preferences/devtools-client.js

@@ -50,8 +50,6 @@ pref("devtools.inspector.showUserAgentStyles", false);
 pref("devtools.inspector.showAllAnonymousContent", false);
 // Show user agent shadow roots
 pref("devtools.inspector.showUserAgentShadowRoots", false);
-// Enable the CSS shapes highlighter
-pref("devtools.inspector.shapesHighlighter.enabled", true);
 // Enable the font highlight-on-hover feature
 pref("devtools.inspector.fonthighlighter.enabled", true);
 // Enable tracking of style changes and the Changes panel in the Inspector

devtools/client/shared/output-parser.js

@@ -4,7 +4,6 @@
 
 "use strict";
 
-const Services = require("Services");
 const {angleUtils} = require("devtools/client/shared/css-angle");
 const {colorUtils} = require("devtools/shared/css/color");
 const {getCSSLexer} = require("devtools/shared/css/lexer");
@@ -36,8 +35,6 @@ const BASIC_SHAPE_FUNCTIONS = ["polygon", "circle", "ellipse", "inset"];
 
 const HTML_NS = "http://www.w3.org/1999/xhtml";
 
-const CSS_SHAPES_ENABLED_PREF = "devtools.inspector.shapesHighlighter.enabled";
-
 /**
  * This module is used to process text for output by developer tools. This means
  * linking JS files with the debugger, CSS files with the style editor, JS
@@ -368,7 +365,6 @@ OutputParser.prototype = {
                          colorUtils.isValidCSSColor(functionText, this.cssColor4)) {
                 this._appendColor(functionText, options);
               } else if (options.expectShape &&
-                         Services.prefs.getBoolPref(CSS_SHAPES_ENABLED_PREF) &&
                          BASIC_SHAPE_FUNCTIONS.includes(token.text)) {
                 this._appendShape(functionText, options);
               } else {

devtools/client/shared/test/browser_outputparser.js

@@ -6,7 +6,6 @@
 const OutputParser = require("devtools/client/shared/output-parser");
 const {initCssProperties, getCssProperties} = require("devtools/shared/fronts/css-properties");
 const { CSS_PROPERTIES_DB} = require("devtools/shared/css/properties-db");
-const CSS_SHAPES_ENABLED_PREF = "devtools.inspector.shapesHighlighter.enabled";
 
 add_task(async function() {
   await addTab("about:blank");
@@ -308,7 +307,7 @@ function testParseAngle(doc, parser) {
 
 function testParseShape(doc, parser) {
   info("Test shape parsing");
-  pushPref(CSS_SHAPES_ENABLED_PREF, true);
+
   const tests = [
     {
       desc: "Polygon shape",