зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1468754 Part 5: Make ChangesView respond to change events. r=rcaliman
Depends on D9176 Differential Revision: https://phabricator.services.mozilla.com/D9178 --HG-- extra : moz-landing-system : lando
This commit is contained in:
Родитель
4b33d8b6f4
Коммит
b190f11a57
|
@ -13,15 +13,24 @@ const ChangesApp = createFactory(require("./components/ChangesApp"));
|
|||
|
||||
const {
|
||||
resetChanges,
|
||||
trackChange,
|
||||
} = require("./actions/changes");
|
||||
|
||||
class ChangesView {
|
||||
constructor(inspector) {
|
||||
this.inspector = inspector;
|
||||
this.store = this.inspector.store;
|
||||
this.toolbox = this.inspector.toolbox;
|
||||
|
||||
this.onAddChange = this.onAddChange.bind(this);
|
||||
this.onClearChanges = this.onClearChanges.bind(this);
|
||||
this.destroy = this.destroy.bind(this);
|
||||
|
||||
// Get the Changes front, and listen to it.
|
||||
this.changesFront = this.toolbox.target.getFront("changes");
|
||||
this.changesFront.on("add-change", this.onAddChange);
|
||||
this.changesFront.on("clear-changes", this.onClearChanges);
|
||||
|
||||
this.init();
|
||||
}
|
||||
|
||||
|
@ -38,6 +47,33 @@ class ChangesView {
|
|||
// TODO: save store and restore/replay on refresh.
|
||||
// Bug 1478439 - https://bugzilla.mozilla.org/show_bug.cgi?id=1478439
|
||||
this.inspector.target.once("will-navigate", this.destroy);
|
||||
|
||||
// Sync the store to the changes stored on the server. The
|
||||
// syncChangesToServer() method is async, but we don't await it since
|
||||
// this method itself is NOT async. The call will be made in its own
|
||||
// time, which is fine since it definitionally brings us up-to-date
|
||||
// with the server at that moment.
|
||||
this.syncChangesToServer();
|
||||
}
|
||||
|
||||
async syncChangesToServer() {
|
||||
// Empty the store.
|
||||
this.onClearChanges();
|
||||
|
||||
// Add back in all the changes from the changesFront.
|
||||
const changes = await this.changesFront.allChanges();
|
||||
changes.forEach((change) => {
|
||||
this.onAddChange(change);
|
||||
});
|
||||
}
|
||||
|
||||
onAddChange(change) {
|
||||
// Turn data into a suitable change to send to the store.
|
||||
this.store.dispatch(trackChange(change));
|
||||
}
|
||||
|
||||
onClearChanges() {
|
||||
this.store.dispatch(resetChanges());
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -45,8 +81,14 @@ class ChangesView {
|
|||
*/
|
||||
destroy() {
|
||||
this.store.dispatch(resetChanges());
|
||||
|
||||
this.changesFront.off("add-change", this.onAddChange);
|
||||
this.changesFront.off("clear-changes", this.onClearChanges);
|
||||
this.changesFront = null;
|
||||
|
||||
this.inspector = null;
|
||||
this.store = null;
|
||||
this.toolbox = null;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче