Bug 1457628 - Remove broken rule for the file input button. r=jfkthame

Inheriting block-size is just plain wrong in presence of calc or percentages. The layout without these rules also matches other browsers, so I see no reason not to do this. Differential Revision: https://phabricator.services.mozilla.com/D37746 --HG-- extra : moz-landing-system : lando
2019-07-12 10:10:43 +00:00 · 2019-07-12 10:10:43 +00:00 · b2494dc0fa
--- a/layout/reftests/forms/input/file/button-height-ref.html
+++ b/layout/reftests/forms/input/file/button-height-ref.html
@ -0,0 +1,6 @@
+<!doctype html>
+<style>
+  /* Android adds a border for some reason */
+  input { border: 0 }
+</style>
+<input type="file">
--- a/layout/reftests/forms/input/file/button-height.html
+++ b/layout/reftests/forms/input/file/button-height.html
@ -0,0 +1,6 @@
+<!doctype html>
+<style>
+  /* Android adds a border for some reason */
+  input { border: 0 }
+</style>
+<input type="file" style="height: 400px">
--- a/layout/reftests/forms/input/file/reftest.list
+++ b/layout/reftests/forms/input/file/reftest.list
@ -9,3 +9,4 @@ fuzzy-if(Android,0-2,0-2) fuzzy-if(OSX,0-34,0-134) fails-if(webrender&&!(cocoaWi
 == label-min-inline-size.html label-min-inline-size-ref.html
 == css-overflow.html css-overflow-ref.html
 == css-display.html css-display-ref.html
+== button-height.html button-height-ref.html
--- a/layout/style/res/forms.css
+++ b/layout/style/res/forms.css
@ -504,7 +504,6 @@ input[type="file"] > label {

 /* button part of file selector */
 input[type="file"] > button {
-  block-size: inherit;
  font-size: unset;
  letter-spacing: unset;
  cursor: unset;