Bug 1809185 - Update libcubeb to revision c96f0d4e. r=cubeb-reviewers,chunmin

Differential Revision: https://phabricator.services.mozilla.com/D166350

media/libcubeb/moz.yaml

@@ -9,8 +9,8 @@ origin:
   description: "Cross platform audio library"
   url: https://github.com/mozilla/cubeb
   license: ISC
-  release: dbc60333f54246cf75253c65989e08d0b8c60e7b (2022-12-14T17:33:27Z).
-  revision: dbc60333f54246cf75253c65989e08d0b8c60e7b
+  release: c96f0d4e7ff8843b96719c15f40f1b8032bccba8 (2023-01-09T16:12:54Z).
+  revision: c96f0d4e7ff8843b96719c15f40f1b8032bccba8
 
 vendoring:
   url: https://github.com/mozilla/cubeb

media/libcubeb/src/cubeb.c

@@ -252,14 +252,12 @@ cubeb_init(cubeb ** context, char const * context_name,
 #if defined(USE_SUN)
     sun_init,
 #endif
-#if defined(USE_OPENSL)
-    opensl_init,
-#endif
-  // TODO: should probably be preferred over OpenSLES when available.
-  // Initialization will fail on old android devices.
 #if defined(USE_AAUDIO)
     aaudio_init,
 #endif
+#if defined(USE_OPENSL)
+    opensl_init,
+#endif
 #if defined(USE_AUDIOTRACK)
     audiotrack_init,
 #endif

media/libcubeb/src/cubeb_jack.cpp

@@ -8,7 +8,7 @@
  */
 #define _DEFAULT_SOURCE
 #define _BSD_SOURCE
-#ifndef __FreeBSD__
+#if !defined(__FreeBSD__) && !defined(__NetBSD__)
 #define _POSIX_SOURCE
 #endif
 #include "cubeb-internal.h"

media/libcubeb/src/cubeb_wasapi.cpp

@@ -1826,12 +1826,14 @@ stop_and_join_render_thread(cubeb_stream * stm, ShutdownPhase phase)
 void
 wasapi_destroy(cubeb * context)
 {
-  auto_lock lock(context->lock);
-  XASSERT(!context->device_collection_enumerator &&
-          !context->collection_notification_client);
+  {
+    auto_lock lock(context->lock);
+    XASSERT(!context->device_collection_enumerator &&
+            !context->collection_notification_client);
 
-  if (context->device_ids) {
-    cubeb_strings_destroy(context->device_ids);
+    if (context->device_ids) {
+      cubeb_strings_destroy(context->device_ids);
+    }
   }
 
   delete context;