Bug 1612723 - Move reader mode l10n to use keycode. r=Gijs,fluent-reviewers,flod

Differential Revision: https://phabricator.services.mozilla.com/D61484

--HG--
extra : moz-landing-system : lando

browser/base/content/browser-sets.inc

@@ -223,10 +223,12 @@
     <key keycode="VK_F11" command="View:FullScreen"/>
 #endif
     <key id="key_toggleReaderMode"
-         data-l10n-id="reader-mode-toggle-shortcut"
          command="View:ReaderView"
-#ifndef XP_WIN
+#ifdef XP_WIN
          modifiers="accel,alt"
+         data-l10n-id="reader-mode-toggle-shortcut-windows"
+#else
+         data-l10n-id="reader-mode-toggle-shortcut-other"
 #endif
          disabled="true"/>
 

browser/locales/en-US/browser/browserSets.ftl

@@ -113,14 +113,11 @@ history-sidebar-shortcut =
 full-screen-shortcut =
     .key = F
 
-# Verify what shortcut for that operation
-# are recommended by the Human Interface Guidelines
-# of each platform for your locale.
-reader-mode-toggle-shortcut =
-    .key = { PLATFORM() ->
-        [windows] VK_F9
-       *[other] R
-    }
+reader-mode-toggle-shortcut-windows =
+    .keycode = VK_F9
+
+reader-mode-toggle-shortcut-other =
+    .key = R
 
 picture-in-picture-toggle-shortcut =
     .key = ]

python/l10n/fluent_migrations/bug_1612723_reader_mode_keycode.py

@@ -0,0 +1,27 @@
+# coding=utf8
+
+# Any copyright is dedicated to the Public Domain.
+# http://creativecommons.org/publicdomain/zero/1.0/
+
+from __future__ import absolute_import
+import fluent.syntax.ast as FTL
+from fluent.migrate.helpers import transforms_from
+
+
+def migrate(ctx):
+    """Bug 1612723 - move reader mode l10n to use keycode, part {index}."""
+
+    ctx.add_transforms(
+        'browser/browser/browserSets.ftl',
+        'browser/browser/browserSets.ftl',
+        transforms_from(
+"""
+reader-mode-toggle-shortcut-windows =
+    .keycode = { COPY(browser_path, "toggleReaderMode.win.keycode") }
+
+reader-mode-toggle-shortcut-other =
+    .key = { COPY(browser_path, "toggleReaderMode.key") }
+""", browser_path="browser/chrome/browser/browser.dtd")
+    )
+
+