Bug 1696491 - when clang errors are present, mark static analysis jobs as failed. r=firefox-build-system-reviewers,mhentges

Our bot was expecting to have tasks that were succeeding, right now we no longer need that
and in a case of a build failure, or in a case of the presence of a checker that asserts itself
as error and not warning we should mark the task red by failing the job.

Differential Revision: https://phabricator.services.mozilla.com/D107656

build/build-clang/clang-tidy-external-linux64.json

@@ -10,8 +10,7 @@
     "cxx": "{MOZ_FETCHES_DIR}/gcc/bin/g++",
     "as": "{MOZ_FETCHES_DIR}/gcc/bin/gcc",
     "patches": [
-        "clang-tidy-ci.patch",
-        "clang-tidy-no-errors.patch"
+        "clang-tidy-ci.patch"
     ],
     "build_clang_tidy_external": true
 }

build/build-clang/clang-tidy-linux64.json

@@ -10,7 +10,6 @@
     "cxx": "{MOZ_FETCHES_DIR}/gcc/bin/g++",
     "as": "{MOZ_FETCHES_DIR}/gcc/bin/gcc",
     "patches": [
-        "clang-tidy-ci.patch",
-        "clang-tidy-no-errors.patch"
+        "clang-tidy-ci.patch"
     ]
 }

build/build-clang/clang-tidy-macosx64.json

@@ -16,7 +16,6 @@
     "ld": "{MOZ_FETCHES_DIR}/clang/bin/clang",
     "patches": [
       "clang-tidy-ci.patch",
-      "clang-tidy-no-errors.patch",
       "compiler-rt-cross-compile.patch",
       "compiler-rt-no-codesign.patch"
     ]

build/build-clang/clang-tidy-no-errors.patch

@@ -1,12 +0,0 @@
-diff --git a/clang-tools-extra/clang-tidy/ClangTidyCheck.cpp b/clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
-index fbf117688bb..dc7235b1450 100644
---- a/clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
-+++ b/clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
-@@ -20,6 +20,7 @@ ClangTidyCheck::ClangTidyCheck(StringRef CheckName, ClangTidyContext *Context)
- 
- DiagnosticBuilder ClangTidyCheck::diag(SourceLocation Loc, StringRef Message,
-                                        DiagnosticIDs::Level Level) {
-+  Level = Level == DiagnosticIDs::Error ? DiagnosticIDs::Warning : Level;
-   return Context->diag(CheckName, Loc, Message, Level);
- }
- 

build/build-clang/clang-tidy-win64.json

@@ -9,7 +9,6 @@
     "cxx": "cl.exe",
     "ml": "ml64.exe",
     "patches": [
-        "clang-tidy-ci.patch",
-        "clang-tidy-no-errors.patch"
+        "clang-tidy-ci.patch"
     ]
 }