Bug 1318228 - NewRunnable defaults to StoreCopyPassByConstLRef - r=froydnj

MozReview-Commit-ID: LmQHthMLUd3

--HG--
extra : rebase_source : 84ab099977d6ab32c6f0afb354569bdcec5ce0a5

xpcom/glue/nsThreadUtils.h

@@ -697,7 +697,7 @@ struct SmartPointerStorageClass
   : mozilla::Conditional<IsRefcountedSmartPointer<T>::value,
                          StorensRefPtrPassByPtr<
                            typename StripSmartPointer<T>::Type>,
-                         StoreCopyPassByValue<T>>
+                         StoreCopyPassByConstLRef<T>>
 {};
 
 template<typename T>
@@ -737,9 +737,9 @@ struct NonParameterStorageClass
 // - T&&       -> StoreCopyPassByRRef<T>         : Store T, pass Move(T).
 // - RefPtr<T>, nsCOMPtr<T>
 //             -> StorensRefPtrPassByPtr<T>      : Store RefPtr<T>, pass T*
-// - Other T   -> StoreCopyPassByValue<T>        : Store T, pass T.
+// - Other T   -> StoreCopyPassByConstLRef<T>    : Store T, pass const T&.
 // Other available explicit options:
-// -              StoreCopyPassByConstLRef<T>    : Store T, pass const T&.
+// -              StoreCopyPassByValue<T>        : Store T, pass T.
 // -              StoreCopyPassByLRef<T>         : Store T, pass T& (of copy!)
 // -              StoreCopyPassByConstPtr<T>     : Store T, pass const T*
 // -              StoreCopyPassByPtr<T>          : Store T, pass T* (of copy!)

xpcom/glue/tests/gtest/TestThreadUtils.cpp

@@ -307,8 +307,8 @@ TEST(ThreadUtils, main)
 
   static_assert(
       mozilla::IsSame< ::detail::ParameterStorage<int>::Type,
-                      StoreCopyPassByValue<int>>::value,
-      "detail::ParameterStorage<int>::Type should be StoreCopyPassByValue<int>");
+                      StoreCopyPassByConstLRef<int>>::value,
+      "detail::ParameterStorage<int>::Type should be StoreCopyPassByConstLRef<int>");
   static_assert(
       mozilla::IsSame< ::detail::ParameterStorage<StoreCopyPassByValue<int>>::Type,
                       StoreCopyPassByValue<int>>::value,