Bug 1509446 - part4 : remove set dirty. r=jya

As the `active cues list` would be automatically contruct when there are any active cues being added or inactive cues being removed, we have no need to use dirty to reset the `active cues list`.

Differential Revision: https://phabricator.services.mozilla.com/D22150

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Alastor Wu 2019-03-07 19:24:02 +00:00
Родитель cb43f6e8f8
Коммит b4902e9582
4 изменённых файлов: 0 добавлений и 13 удалений

Просмотреть файл

@ -230,9 +230,6 @@ void TextTrackManager::RemoveTextTrack(TextTrack* aTextTrack,
void TextTrackManager::DidSeek() {
WEBVTT_LOG("%p DidSeek", this);
if (mTextTracks) {
mTextTracks->DidSeek();
}
if (mMediaElement) {
mLastTimeMarchesOnCalled = mMediaElement->CurrentTime();
WEBVTT_LOGV("DidSeek set mLastTimeMarchesOnCalled %lf",

Просмотреть файл

@ -128,7 +128,6 @@ void TextTrack::AddCue(TextTrackCue& aCue) {
mediaElement->NotifyCueAdded(aCue);
}
}
SetDirty();
}
void TextTrack::RemoveCue(TextTrackCue& aCue, ErrorResult& aRv) {
@ -145,7 +144,6 @@ void TextTrack::RemoveCue(TextTrackCue& aCue, ErrorResult& aRv) {
mediaElement->NotifyCueRemoved(aCue);
}
}
SetDirty();
}
void TextTrack::SetCuesDirty() {
@ -212,7 +210,6 @@ void TextTrack::NotifyCueUpdated(TextTrackCue* aCue) {
mediaElement->NotifyCueUpdated(aCue);
}
}
SetDirty();
}
void TextTrack::GetLabel(nsAString& aLabel) const {

Просмотреть файл

@ -105,12 +105,6 @@ void TextTrackList::RemoveTextTrack(TextTrack* aTrack) {
}
}
void TextTrackList::DidSeek() {
for (uint32_t i = 0; i < mTextTracks.Length(); i++) {
mTextTracks[i]->SetDirty();
}
}
class TrackEventRunner : public Runnable {
public:
TrackEventRunner(TextTrackList* aList, Event* aEvent)

Просмотреть файл

@ -50,7 +50,6 @@ class TextTrackList final : public DOMEventTargetHelper {
void AddTextTrack(TextTrack* aTextTrack, const CompareTextTracks& aCompareTT);
void RemoveTextTrack(TextTrack* aTrack);
void DidSeek();
HTMLMediaElement* GetMediaElement();
void SetTextTrackManager(TextTrackManager* aTextTrackManager);