Bug 1466731 [wpt PR 11337] - [LayoutNG] Fix flex BODY in quirks mode, a=testonly

Automatic update from web-platform-tests[LayoutNG] Fix flex BODY in quirks mode

We were not updating margins correctly inside NGBlockNode::RunOldLayout.
Symptom was that BODY(flex) block size was too big when HTML had margins
inside quirks mode.

Another side effect of this fix is two crashes have gone away.

Added explicit test case for BODY(flex) in quirks mode.

Bug: 849490
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id0ce0910144c81fc254646110424f36c898f9ebd
Reviewed-on: https://chromium-review.googlesource.com/1086381
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564629}

--

wpt-commits: 8bafc093504c38befdb4e63d9d1d1dcee9bf81e4
wpt-pr: 11337
This commit is contained in:
Aleks Totic 2018-06-25 22:10:59 +00:00
Родитель 65c6a9c759
Коммит b5a5888f50
3 изменённых файлов: 62 добавлений и 0 удалений

Просмотреть файл

@ -115513,6 +115513,18 @@
{}
]
],
"css/css-flexbox/flexbox_quirks_body.html": [
[
"/css/css-flexbox/flexbox_quirks_body.html",
[
[
"/css/css-flexbox/reference/flexbox_quirks_body-ref.html",
"=="
]
],
{}
]
],
"css/css-flexbox/flexbox_rowspan-overflow-automatic.html": [
[
"/css/css-flexbox/flexbox_rowspan-overflow-automatic.html",
@ -242011,6 +242023,11 @@
{}
]
],
"css/css-flexbox/reference/flexbox_quirks_body-ref.html": [
[
{}
]
],
"css/css-flexbox/reference/flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom-ref.html": [
[
{}
@ -506440,6 +506457,10 @@
"3f8ea7d7e6b8ab8d0473aebfdedc108c34f732a1",
"reftest"
],
"css/css-flexbox/flexbox_quirks_body.html": [
"b39447c4a7eba1ec321ae469fbd6442b1ef05445",
"reftest"
],
"css/css-flexbox/flexbox_rowspan-overflow-automatic.html": [
"d13114027f1508a37406ad333f8b39882eba9fe8",
"reftest"
@ -507192,6 +507213,10 @@
"a69d1222f1ea291ef87ca0e996de93171aca28aa",
"support"
],
"css/css-flexbox/reference/flexbox_quirks_body-ref.html": [
"307f46b4cedc1acf40c0a267b1175098a51c7245",
"support"
],
"css/css-flexbox/reference/flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom-ref.html": [
"696a426eca7e126eef17fc995bbe794ae60af0ca",
"support"

Просмотреть файл

@ -0,0 +1,20 @@
<!doctype quirks><!-- Intentional quirks mode -->
<title>CSS Test: Flex body in quirks mode</title>
<link rel="author" title="Aleks Totic" href="atotic@chromium.org">
<link rel="help" href="https://www.w3.org/TR/css-flexbox-1/#main-sizing" title="9.3 Main Size Determination">
<link rel="help" href="https://quirks.spec.whatwg.org/#the-body-element-fills-the-html-element-quirk" title="The body element fills the html element quirk">
<link rel="match" href="./reference/flexbox_quirks_body-ref.html">
<style>
html {
margin:3px 6px 9px 12px;
padding: 0px;
background-color: green;
}
body {
display: flex;
margin: 7px 11px 14px 23px;
padding: 0px;
background-color: yellow;
}
</style>
Flex body in quirks mode should fill viewport except for margins.

Просмотреть файл

@ -0,0 +1,17 @@
<!doctype quirks>
<title>CSS Test: Flex body in quirks mode</title>
<link rel="author" title="Aleks Totic" href="atotic@chromium.org">
<style>
html {
margin:3px 6px 9px 12px;
padding: 0px;
background-color: green;
}
body {
display: block;
margin: 7px 11px 14px 23px;;
padding: 0px;
background-color: yellow;
}
</style>
Flex body in quirks mode should fill viewport except for margins.