Bug 1360282 - Remove _setVisibility helper now that the sidebar is always shown through show();r=Gijs

MozReview-Commit-ID: FWJshLtYZ3h

--HG--
extra : rebase_source : ed67bebb88ca18ba009d3b943d52086e648161f4

browser/base/content/browser-sidebar.js

@@ -257,19 +257,6 @@ var SidebarUI = {
     this._title.value = value;
   },
 
-  /**
-   * Internal helper to show/hide the box and splitter elements.
-   *
-   * @param {bool} visible
-   */
-  _setVisibility(visible) {
-    this._box.hidden = !visible;
-    this._splitter.hidden = !visible;
-    if (visible) {
-      this.setPosition();
-    }
-  },
-
   /**
    * Toggle the visibility of the sidebar. If the sidebar is hidden or is open
    * with a different commandID, then the sidebar will be opened using the
@@ -327,7 +314,8 @@ var SidebarUI = {
         }
       }
 
-      this._setVisibility(true);
+      this._box.hidden = this._splitter.hidden = false;
+      this.setPosition();
 
       this.hideSwitcherPanel();
 
@@ -401,7 +389,7 @@ var SidebarUI = {
     sidebarBroadcaster.removeAttribute("checked");
     this._box.setAttribute("sidebarcommand", "");
     this._title.value = "";
-    this._setVisibility(false);
+    this._box.hidden = this._splitter.hidden = true;
 
     let selBrowser = gBrowser.selectedBrowser;
     selBrowser.focus();