Bug 1521072 - Log wpt reftest screenshots on fail when running mach, r=ato

On CI we only want to log screenshots when something unexpected happens since anything
else is rather wasteful of resources. But locally getting screenshots for expected
failures seems helpful for debugging, so worth making the default. Hopefully this isn't
too confusing for people just checking if their patch regresses anything rather than
actively working on fixing failures.

Depends on D16973

Differential Revision: https://phabricator.services.mozilla.com/D16974

--HG--
extra : moz-landing-system : lando

testing/web-platform/mach_commands.py

@@ -80,6 +80,9 @@ class WebPlatformTestsRunnerSetup(MozbuildObject):
         if kwargs["lsan_dir"] is None:
             kwargs["lsan_dir"] = os.path.join(self.topsrcdir, "build", "sanitizers")
 
+        if kwargs["reftest_screenshot"] is None:
+            kwargs["reftest_screenshot"] = "fail"
+
         kwargs["capture_stdio"] = True
 
         return kwargs

testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py

@@ -268,7 +268,7 @@ scheme host and port.""")
     gecko_group.add_argument("--reftest-external", dest="reftest_internal", action="store_false",
                              help="Disable reftest runner implemented inside Marionette")
     gecko_group.add_argument("--reftest-screenshot", dest="reftest_screenshot", action="store",
-                             choices=["always", "fail", "unexpected"], default="unexpected",
+                             choices=["always", "fail", "unexpected"], default=None,
                              help="With --reftest-internal, when to take a screenshot")
     gecko_group.add_argument("--chaos", dest="chaos_mode_flags", action="store",
                              nargs="?", const=0xFFFFFFFF, type=int,
@@ -530,6 +530,9 @@ def check_args(kwargs):
     if kwargs["lsan_dir"] is None:
         kwargs["lsan_dir"] = kwargs["prefs_root"]
 
+    if kwargs["reftest_screenshot"] is None:
+        kwargs["reftest_screenshot"] = "unexpected"
+
     return kwargs