From b768ed3d0f5a2a7ad7241dcab061e13d292d2057 Mon Sep 17 00:00:00 2001 From: Dhyey Thakore Date: Tue, 13 Aug 2019 19:56:06 +0000 Subject: [PATCH] Bug 1573580 - Handle corner case which caused inline preview to stop working r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D41794 --HG-- extra : moz-landing-system : lando --- devtools/client/debugger/src/actions/pause/inlinePreview.js | 4 ++-- .../client/debugger/src/components/Editor/InlinePreview.js | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/devtools/client/debugger/src/actions/pause/inlinePreview.js b/devtools/client/debugger/src/actions/pause/inlinePreview.js index b016a33c23a9..c3320929b3d4 100644 --- a/devtools/client/debugger/src/actions/pause/inlinePreview.js +++ b/devtools/client/debugger/src/actions/pause/inlinePreview.js @@ -198,9 +198,9 @@ function getExpressionNameAndValue( const property: Object = properties.find( prop => prop.name === meta.property ); - displayValue = property.contents.value; + displayValue = property && property.contents.value; displayName += `.${meta.property}`; - } else { + } else if (displayValue && displayValue.preview) { const { ownProperties } = displayValue.preview; for (const prop in ownProperties) { if (prop === meta.property) { diff --git a/devtools/client/debugger/src/components/Editor/InlinePreview.js b/devtools/client/debugger/src/components/Editor/InlinePreview.js index 4cf71f7c28f5..f7064492367d 100644 --- a/devtools/client/debugger/src/components/Editor/InlinePreview.js +++ b/devtools/client/debugger/src/components/Editor/InlinePreview.js @@ -22,7 +22,6 @@ class InlinePreview extends PureComponent { showInScopes(variable: string) { // TODO: focus on variable value in the scopes sidepanel // we will need more info from parent comp - console.log(`show ${variable}`); } render() {