Backed out changeset 9f7039b0b86c (bug 1772546) as requested by the dev. CLOSED TREE

This commit is contained in:
Marian-Vasile Laza 2022-06-04 05:28:58 +03:00
Родитель 6e2fd8c6e0
Коммит b854f79c84
2 изменённых файлов: 0 добавлений и 45 удалений

Просмотреть файл

@ -1296,7 +1296,6 @@ class PictureInPictureToggleChild extends JSWindowActorChild {
}
class PictureInPictureChild extends JSWindowActorChild {
#subtitlesEnabled = false;
// A weak reference to this PiP window's video element
weakVideo = null;
@ -1478,10 +1477,6 @@ class PictureInPictureChild extends JSWindowActorChild {
return;
}
if (!this.isSubtitlesEnabled) {
this.isSubtitlesEnabled = true;
}
let allCuesArray = [...textTrackCues];
// Re-order cues
this.getOrderedWebVTTCues(allCuesArray);
@ -2249,26 +2244,6 @@ class PictureInPictureChild extends JSWindowActorChild {
/* ignore any exception from setting video.currentTime */
}
}
get isSubtitlesEnabled() {
return this.#subtitlesEnabled;
}
set isSubtitlesEnabled(val) {
if (val) {
Services.telemetry.recordEvent(
"pictureinpicture",
"subtitles_shown",
"subtitles",
null,
{
webVTTSubtitles: (!!this.getWeakVideo().textTracks
?.length).toString(),
}
);
}
this.#subtitlesEnabled = val;
}
}
/**
@ -2434,9 +2409,6 @@ class PictureInPictureChildVideoWrapper {
* @param text The captions to be shown on the PiP window
*/
updatePiPTextTracks(text) {
if (!this.#PictureInPictureChild.isSubtitlesEnabled) {
this.#PictureInPictureChild.isSubtitlesEnabled = true;
}
let pipWindowTracksContainer = this.#PictureInPictureChild.document.getElementById(
"texttracks"
);

Просмотреть файл

@ -2609,23 +2609,6 @@ pictureinpicture:
- 1756703
expiry_version: "never"
release_channel_collection: opt-out
subtitles_shown:
objects: ["subtitles"]
description: >
Records if subtitles are shown in the Picture-in-Picture window.
extra_keys:
webVTTSubtitles: Will be true or false
notification_emails:
- mconley@mozilla.com
- mhowell@mozilla.com
products:
- "firefox"
record_in_processes:
- "content"
bug_numbers:
- 1772546
expiry_version: "never"
release_channel_collection: opt-out
pictureinpicture.settings:
enable: