From b8d9847e9e4f9098bdb25f31dbb5c5c905f628f1 Mon Sep 17 00:00:00 2001 From: "travis%sedsystems.ca" Date: Tue, 15 Mar 2005 23:59:46 +0000 Subject: [PATCH] Bug 284811 : Remove %FORM from enter_bug.cgi classification code Patch by Teemu Mannermaa r=LpSolit a=myk --- webtools/bugzilla/enter_bug.cgi | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/webtools/bugzilla/enter_bug.cgi b/webtools/bugzilla/enter_bug.cgi index a242c1883f56..634bc621549d 100755 --- a/webtools/bugzilla/enter_bug.cgi +++ b/webtools/bugzilla/enter_bug.cgi @@ -76,10 +76,10 @@ if (!defined $product) { if ( ! Param('useclassification') ) { # just pick the default one - $::FORM{'classification'}=(keys %::classdesc)[0]; + $cgi->param(-name => 'classification', -value => (keys %::classdesc)[0]); } - if (!defined $::FORM{'classification'}) { + if (!$cgi->param('classification')) { my %classdesc; my %classifications; @@ -97,7 +97,7 @@ if (!defined $product) { $vars->{'classifications'} = \%classifications; $vars->{'target'} = "enter_bug.cgi"; - $vars->{'format'} = $::FORM{'format'}; + $vars->{'format'} = $cgi->param('format'); $vars->{'cloned_bug_id'} = $cgi->param('cloned_bug_id'); @@ -106,15 +106,14 @@ if (!defined $product) { || ThrowTemplateError($template->error()); exit; } - $::FORM{'classification'} = (keys %classdesc)[0]; - $::MFORM{'classification'} = [$::FORM{'classification'}]; + $cgi->param(-name => 'classification', -value => (keys %classdesc)[0]); } my %products; foreach my $p (@enterable_products) { if (CanEnterProduct($p)) { - if (IsInClassification($::FORM{'classification'},$p) || - $::FORM{'classification'} eq "__all") { + if (IsInClassification(scalar $cgi->param('classification'),$p) || + $cgi->param('classification') eq "__all") { $products{$p} = $::proddesc{$p}; } } @@ -129,11 +128,11 @@ if (!defined $product) { if ( ! Param('useclassification') ) { @{$classifications{"all"}} = keys %products; } - elsif ($::FORM{'classification'} eq "__all") { + elsif ($cgi->param('classification') eq "__all") { %classifications = %::classifications; } else { - $classifications{$::FORM{'classification'}} = - $::classifications{$::FORM{'classification'}}; + $classifications{$cgi->param('classification')} = + $::classifications{$cgi->param('classification')}; } $vars->{'proddesc'} = \%products; $vars->{'classifications'} = \%classifications;