Bug 1463373 - Throw rather than assert if buggy module resolve hook returns a module we didn't expect r=anba

js/src/builtin/Module.js

@@ -350,8 +350,8 @@ function InnerModuleInstantiation(module, stack, index)
     }
 
     // Step 3
-    assert(module.status === MODULE_STATUS_UNINSTANTIATED,
-          "Bad module status in ModuleDeclarationInstantiation");
+    if (module.status !== MODULE_STATUS_UNINSTANTIATED)
+        ThrowInternalError(JSMSG_BAD_MODULE_STATUS);
 
     // Steps 4
     ModuleSetStatus(module, MODULE_STATUS_INSTANTIATING);

js/src/jit-test/tests/modules/bug-1463373.js

@@ -0,0 +1,11 @@
+// |jit-test| error: InternalError
+
+let m = parseModule(`
+  let c = parseModule(\`
+    import "a";
+  \`);
+  c.declarationInstantiation();
+`);
+setModuleResolveHook(function(module, specifier) { return m; });
+m.declarationInstantiation();
+m.evaluation();