Bug 454483 - Clean up unused variables in gfx/; r=vladimir; (with nits by sgautherie)

gfx/src/thebes/nsThebesFontEnumerator.cpp

@@ -124,7 +124,7 @@ nsThebesFontEnumerator::GetDefaultFont(const char *aLangGroup,
 NS_IMETHODIMP
 nsThebesFontEnumerator::UpdateFontList(PRBool *_retval)
 {
-    nsresult rv = gfxPlatform::GetPlatform()->UpdateFontList();
+    gfxPlatform::GetPlatform()->UpdateFontList();
     *_retval = PR_FALSE; // always return false for now
     return NS_OK;
 }

gfx/src/thebes/nsThebesRenderingContext.cpp

@@ -98,8 +98,6 @@ nsThebesRenderingContext::Init(nsIDeviceContext* aContext, gfxASurface *aThebesS
 {
     PR_LOG(gThebesGFXLog, PR_LOG_DEBUG, ("## %p nsTRC::Init ctx %p thebesSurface %p\n", this, aContext, aThebesSurface));
 
-    nsThebesDeviceContext *thebesDC = static_cast<nsThebesDeviceContext*>(aContext);
-
     mDeviceContext = aContext;
     mWidget = nsnull;
 
@@ -126,8 +124,6 @@ nsThebesRenderingContext::Init(nsIDeviceContext* aContext, nsIWidget *aWidget)
 {
     PR_LOG(gThebesGFXLog, PR_LOG_DEBUG, ("## %p nsTRC::Init ctx %p widget %p\n", this, aContext, aWidget));
 
-    nsThebesDeviceContext *thebesDC = static_cast<nsThebesDeviceContext*>(aContext);
-
     mDeviceContext = aContext;
     mWidget = aWidget;
 

gfx/thebes/src/gfxFont.cpp

@@ -2328,9 +2328,9 @@ gfxTextRun::CopyGlyphDataFrom(gfxTextRun *aSource, PRUint32 aStart,
         NS_ASSERTION(font != lastFont, "Glyphruns not coalesced?");
 #ifdef DEBUG
         lastFont = font;
+        PRUint32 end = iter.GetStringEnd();
 #endif
         PRUint32 start = iter.GetStringStart();
-        PRUint32 end = iter.GetStringEnd();
         NS_ASSERTION(aSource->IsClusterStart(start),
                      "Started word in the middle of a cluster...");
         NS_ASSERTION(end == aSource->GetLength() || aSource->IsClusterStart(end),

gfx/thebes/src/gfxFontUtils.cpp

@@ -295,7 +295,7 @@ gfxFontUtils::ReadCMAPTableFormat4(PRUint8 *aBuf, PRInt32 aLength, gfxSparseBitS
         if (idRangeOffset == 0) {
             aCharacterMap.SetRange(startCount, endCount);
         } else {
-            const PRUint16 idDelta = ReadShortAt16(idDeltas, i);
+            // const PRUint16 idDelta = ReadShortAt16(idDeltas, i); // Unused: self-documenting.
             for (PRUint32 c = startCount; c <= endCount; ++c) {
                 if (c == 0xFFFF)
                     break;
@@ -366,7 +366,7 @@ gfxFontUtils::ReadCMAP(PRUint8 *aBuf, PRUint32 aBufLength, gfxSparseBitSet& aCha
         EncodingIDUCS4ForMicrosoftPlatform = 10
     };
 
-    PRUint16 version = ReadShortAt(aBuf, OffsetVersion);
+    // PRUint16 version = ReadShortAt(aBuf, OffsetVersion); // Unused: self-documenting.
     PRUint16 numTables = ReadShortAt(aBuf, OffsetNumTables);
 
     // save the format and offset we want here

gfx/thebes/src/gfxPangoFonts.cpp

@@ -1643,7 +1643,9 @@ gfxPangoFontGroup::CreateGlyphRunsItemizing(gfxTextRun *aTextRun,
     GList *items = pango_itemize_with_base_dir(context, dir, aUTF8, 0, aUTF8Length, nsnull, nsnull);
 
     PRUint32 utf16Offset = 0;
+#ifdef DEBUG
     PRBool isRTL = aTextRun->IsRightToLeft();
+#endif
     GList *pos = items;
     PangoGlyphString *glyphString = pango_glyph_string_new();
     if (!glyphString)