Bug 1826622 - Constrain autocomplete popup like select. r=Gijs,sgalich

Depends on D175039

Differential Revision: https://phabricator.services.mozilla.com/D175040

browser/components/extensions/ExtensionPopups.jsm

@@ -319,7 +319,7 @@ class BasePopup {
     browser.setAttribute("tooltip", "aHTMLTooltip");
     browser.setAttribute("contextmenu", "contentAreaContextMenu");
     browser.setAttribute("autocompletepopup", "PopupAutoComplete");
-    browser.setAttribute("selectmenuconstrained", "false");
+    browser.setAttribute("constrainpopups", "false");
 
     // Ensure the browser will initially load in the same group as other
     // browsers from the same extension.

toolkit/actors/AutoCompleteParent.sys.mjs

@@ -258,6 +258,7 @@ export class AutoCompleteParent extends JSWindowActorParent {
       this.openedPopup._normalMaxRows = this.openedPopup.maxRows;
       this.openedPopup.mInput.maxRows = 10;
     }
+    browser.constrainPopup(this.openedPopup);
     this.openedPopup.addEventListener("popuphidden", this);
     this.openedPopup.addEventListener("popupshowing", this);
     this.openedPopup.openPopupAtScreenRect(

toolkit/actors/SelectParent.sys.mjs

@@ -309,18 +309,7 @@ export var SelectParentHelper = {
 
     menupopup.classList.toggle("isOpenedViaTouch", isOpenedViaTouch);
 
-    if (browser.getAttribute("selectmenuconstrained") != "false") {
-      let constraintRect = browser.getBoundingClientRect();
-      constraintRect = new win.DOMRect(
-        constraintRect.left + win.mozInnerScreenX,
-        constraintRect.top + win.mozInnerScreenY,
-        constraintRect.width,
-        constraintRect.height
-      );
-      menupopup.setConstraintRect(constraintRect);
-    } else {
-      menupopup.setConstraintRect(new win.DOMRect(0, 0, 0, 0));
-    }
+    browser.constrainPopup(menupopup);
     menupopup.openPopupAtScreenRect(
       AppConstants.platform == "macosx" ? "selection" : "after_start",
       rect.left,

toolkit/components/printing/content/print.js

@@ -86,7 +86,7 @@ document.addEventListener(
   e => {
     window._initialized = PrintEventHandler.init().catch(e => console.error(e));
     ourBrowser.setAttribute("flex", "0");
-    ourBrowser.setAttribute("selectmenuconstrained", "false");
+    ourBrowser.setAttribute("constrainpopups", "false");
     ourBrowser.classList.add("printSettingsBrowser");
     ourBrowser.closest(".dialogBox")?.classList.add("printDialogBox");
   },

toolkit/content/widgets/browser-custom-element.js

@@ -995,6 +995,21 @@
       );
     }
 
+    constrainPopup(popup) {
+      if (this.getAttribute("constrainpopups") != "false") {
+        let constraintRect = this.getBoundingClientRect();
+        constraintRect = new DOMRect(
+          constraintRect.left + window.mozInnerScreenX,
+          constraintRect.top + window.mozInnerScreenY,
+          constraintRect.width,
+          constraintRect.height
+        );
+        popup.setConstraintRect(constraintRect);
+      } else {
+        popup.setConstraintRect(new DOMRect(0, 0, 0, 0));
+      }
+    }
+
     construct() {
       elementsToDestroyOnUnload.add(this);
       this.resetFields();