зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1797011 Part 3 - Delete nsFrameList's copy assigment operator. r=emilio
This patch doesn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D160015
This commit is contained in:
Родитель
b91a315ae3
Коммит
babc81bc9c
|
@ -3843,7 +3843,7 @@ void nsCSSFrameConstructor::ConstructFrameFromItemInternal(
|
||||||
childList.DestroyFrames();
|
childList.DestroyFrames();
|
||||||
}
|
}
|
||||||
|
|
||||||
childList = newList;
|
childList = std::move(newList);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!(bits & FCDATA_ALLOW_GRID_FLEX_COLUMN) ||
|
if (!(bits & FCDATA_ALLOW_GRID_FLEX_COLUMN) ||
|
||||||
|
|
|
@ -5626,7 +5626,7 @@ void nsBlockFrame::SetOverflowOutOfFlows(nsFrameList&& aList,
|
||||||
} else if (HasAnyStateBits(NS_BLOCK_HAS_OVERFLOW_OUT_OF_FLOWS)) {
|
} else if (HasAnyStateBits(NS_BLOCK_HAS_OVERFLOW_OUT_OF_FLOWS)) {
|
||||||
NS_ASSERTION(aPropValue == GetProperty(OverflowOutOfFlowsProperty()),
|
NS_ASSERTION(aPropValue == GetProperty(OverflowOutOfFlowsProperty()),
|
||||||
"prop value mismatch");
|
"prop value mismatch");
|
||||||
*aPropValue = aList;
|
*aPropValue = std::move(aList);
|
||||||
} else {
|
} else {
|
||||||
SetProperty(OverflowOutOfFlowsProperty(),
|
SetProperty(OverflowOutOfFlowsProperty(),
|
||||||
new (PresShell()) nsFrameList(std::move(aList)));
|
new (PresShell()) nsFrameList(std::move(aList)));
|
||||||
|
|
|
@ -101,10 +101,7 @@ class nsFrameList {
|
||||||
// nsFrameList is a move-only class by default. Use Clone() if you really want
|
// nsFrameList is a move-only class by default. Use Clone() if you really want
|
||||||
// a copy of this list.
|
// a copy of this list.
|
||||||
nsFrameList(const nsFrameList& aOther) = delete;
|
nsFrameList(const nsFrameList& aOther) = delete;
|
||||||
|
nsFrameList& operator=(const nsFrameList& aOther) = delete;
|
||||||
// XXX: ideally, copy assignment should be removed because we should use move
|
|
||||||
// assignment to transfer the ownership.
|
|
||||||
nsFrameList& operator=(const nsFrameList& aOther) = default;
|
|
||||||
nsFrameList Clone() const { return nsFrameList(mFirstChild, mLastChild); }
|
nsFrameList Clone() const { return nsFrameList(mFirstChild, mLastChild); }
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Загрузка…
Ссылка в новой задаче