From bd409af798503b24772269d7a21d2cd86ca812e5 Mon Sep 17 00:00:00 2001 From: Anthony Frehner Date: Tue, 28 Apr 2020 11:45:02 +0000 Subject: [PATCH] Bug 1633228 [wpt PR 23254] - Fix mobile table, a=testonly Automatic update from web-platform-tests for larger tables on mobile, you have to wrap in a div and set overflow to auto so that they'll scroll the div instead of the window -- wpt-commits: 5e7cbed423a3040dc8ca50359dd033a46dba5cf4 wpt-pr: 23254 --- testing/web-platform/tests/docs/assets/custom.css | 4 ++++ .../tests/docs/writing-tests/making-a-testing-plan.md | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/testing/web-platform/tests/docs/assets/custom.css b/testing/web-platform/tests/docs/assets/custom.css index a5f59ce7721c..58a982579f06 100644 --- a/testing/web-platform/tests/docs/assets/custom.css +++ b/testing/web-platform/tests/docs/assets/custom.css @@ -4,4 +4,8 @@ div.body { #video-introduction-transcript iframe { max-width: 100%; +} + +.table-container { + overflow: auto; } \ No newline at end of file diff --git a/testing/web-platform/tests/docs/writing-tests/making-a-testing-plan.md b/testing/web-platform/tests/docs/writing-tests/making-a-testing-plan.md index 0f5673016c05..520c5a32e070 100644 --- a/testing/web-platform/tests/docs/writing-tests/making-a-testing-plan.md +++ b/testing/web-platform/tests/docs/writing-tests/making-a-testing-plan.md @@ -482,6 +482,8 @@ use [git](https://git-scm.com) to perform more powerful searches. The following table lists some common search criteria and examples of how they can be expressed using regular expressions: +
+ ```eval_rst ================================= ================== ========================== Criteria Example match Example regular expression @@ -494,6 +496,8 @@ CSS property name ``style="foo: 4"`` ``([{;=\"']|\s|^)foo\s+:`` ================================= ================== ========================== ``` +
+ Bear in mind that searches like this are not necessarily exhaustive. Depending on the feature, it may be difficult (or even impossible) to write a query that correctly identifies all relevant tests. This strategy can give a helpful