Bug 1412356 - Don't invoke client.mk from mobile l10n automation; r=chmanchester

The old code was simply running configure and manually invoking some
make targets via client.mk. These can both be done via `mach`.

As part of the change, the build targets have been consolidated. There
is still an abstraction leak here. But at least we aren't using client.mk.

MozReview-Commit-ID: 7oMXPWPZS6V

--HG--
extra : rebase_source : 6d632dc086d79a17e577da66336c77003d963f67
This commit is contained in:
Gregory Szorc 2017-10-27 10:07:52 -07:00
Родитель 2fdc4b7cdf
Коммит be33077ff5
1 изменённых файлов: 15 добавлений и 13 удалений

Просмотреть файл

@ -426,26 +426,28 @@ class MobileSingleLocale(MockMixin, LocalesMixin, ReleaseMixin,
def _setup_configure(self, buildid=None):
dirs = self.query_abs_dirs()
env = self.query_repack_env()
make = self.query_exe("make")
if self.run_command_m([make, "-f", "client.mk", "configure"],
mach = os.path.join(dirs['abs_mozilla_dir'], 'mach')
if self.run_command_m([sys.executable, mach, 'configure'],
cwd=dirs['abs_mozilla_dir'],
env=env,
error_list=MakefileErrorList):
self.fatal("Configure failed!")
# Run 'make export' in objdir/config to get nsinstall
self.run_command_m([make, 'export'],
cwd=os.path.join(dirs['abs_objdir'], 'config'),
env=env,
error_list=MakefileErrorList,
halt_on_failure=True)
# Invoke the build system to get nsinstall and buildid.h.
targets = [
'config/export',
'buildid.h',
]
# Run 'make buildid.h' in objdir/ to get the buildid.h file
cmd = [make, 'buildid.h']
# Force the buildid if one is defined.
if buildid:
cmd.append('MOZ_BUILD_DATE=%s' % str(buildid))
self.run_command_m(cmd,
cwd=dirs['abs_objdir'],
env = dict(env)
env['MOZ_BUILD_DATE'] = str(buildid)
self.run_command_m([sys.executable, mach, 'build'] + targets,
cwd=dirs['abs_mozilla_dir'],
env=env,
error_list=MakefileErrorList,
halt_on_failure=True)